[network] Make icmp ping and arp ping optional by presence thing#18083
Merged
jlaur merged 3 commits intoopenhab:mainfrom Jan 11, 2025
Merged
[network] Make icmp ping and arp ping optional by presence thing#18083jlaur merged 3 commits intoopenhab:mainfrom
jlaur merged 3 commits intoopenhab:mainfrom
Conversation
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
jlaur
reviewed
Jan 10, 2025
....binding.network/src/main/java/org/openhab/binding/network/internal/utils/LatencyParser.java
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.network/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
Contributor
Author
|
@jlaur Thanks for the feedback. I have done the requested changes. |
jlaur
requested changes
Jan 10, 2025
Contributor
jlaur
left a comment
There was a problem hiding this comment.
I found a few more things to update after renaming the ICMP ping parameter.
bundles/org.openhab.binding.network/src/main/resources/OH-INF/i18n/network.properties
Outdated
Show resolved
Hide resolved
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
Contributor
Author
|
Adjustments done. |
GearrelW
pushed a commit
to GearrelW/openhab-addons
that referenced
this pull request
Jan 12, 2025
…nhab#18083) Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
chilobo
pushed a commit
to chilobo/openhab-addons
that referenced
this pull request
Feb 10, 2025
…nhab#18083) Signed-off-by: Mark Herwege <mark.herwege@telenet.be> Signed-off-by: Christian Koch <78686276+chilobo@users.noreply.github.com>
phenix1990
pushed a commit
to phenix1990/openhab-addons
that referenced
this pull request
Jul 31, 2025
…nhab#18083) Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
Nadahar
pushed a commit
to Nadahar/openhab-addons
that referenced
this pull request
Oct 3, 2025
…nhab#18083) Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
This was referenced Oct 3, 2025
lsiepel
pushed a commit
that referenced
this pull request
Oct 11, 2025
* [network] Make icmp ping and arp ping optional by presence thing (#18083) Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was trying to use the Network binding to create a ping reply log to my router. It turned out to be hard to get a good result. While the presence thing has been optimized for presence detection, it does not allow good and comparable ping latency tracking.
The issues I ran into:
A workaround was to use an IPv6 destination address, as that would exclude ARP ping, but it is still only a workaround.
This PR does: