Merged
Conversation
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
andrewfg
added
the
enhancement
jlaur
reviewed
Apr 17, 2025
Contributor
jlaur
left a comment
jlaur
left a comment
There was a problem hiding this comment.
Again some comments on my way of getting into the new tagging logic.
bundles/org.openhab.binding.harmonyhub/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.harmonyhub/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Contributor
Author
jlaur
approved these changes
May 12, 2025
Contributor
jlaur
left a comment
jlaur
left a comment
There was a problem hiding this comment.
Thanks, LGTM. Sorry for the missing feedback, this went off my radar together with my overview of all the tagging PR's and discussions.
bundles/org.openhab.binding.harmonyhub/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
phenix1990
pushed a commit
to phenix1990/openhab-addons
that referenced
this pull request
Jul 31, 2025
* Add semantic tags Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds semantic tags
Signed-off-by: Andrew Fiddian-Green software@whitebear.ch