Skip to content

Bindings A thru F: Add equipment tags#18549

Merged
lsiepel merged 18 commits intoopenhab:mainfrom
andrewfg:equipment-tags
Apr 23, 2025
Merged

Bindings A thru F: Add equipment tags#18549
lsiepel merged 18 commits intoopenhab:mainfrom
andrewfg:equipment-tags

Conversation

@andrewfg
Copy link
Contributor

@andrewfg andrewfg commented Apr 14, 2025

This PR adds Equipment tags (only) to bindings A thru F.

  • It adds Equipment tags where it is relatively easy to determine the type of Equipment from the context.
  • It does NOT add any Point or Property tags => I am hoping that you code contributors will provide these.

See Equipment tags in this table for reference.

Signed-off-by: Andrew Fiddian-Green software@whitebear.ch

Edit: Depends on: openhab/openhab-core#4738

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@andrewfg
Copy link
Contributor Author

@jlaur you may be interested in the tag usage statistics so far.

Copy link
Contributor

@mherwege mherwege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for elroconnects

Copy link
Member

@ccutrer ccutrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for bondhome

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@jlaur
Copy link
Contributor

jlaur commented Apr 22, 2025

LGTM for boschindego as well.

Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, @andrewfg Covered all files. Some questions and suggestions to look at.

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@lsiepel lsiepel added the awaiting other PR Depends on another PR label Apr 22, 2025
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When related PR is merged, this can also be merged. Thanks. LGTM

Copy link
Contributor

@mherwege mherwege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for elroconnects

@lsiepel lsiepel removed the awaiting other PR Depends on another PR label Apr 23, 2025
@lsiepel lsiepel merged commit fa4d390 into openhab:main Apr 23, 2025
2 of 4 checks passed
@lsiepel lsiepel added this to the 5.0 milestone Apr 23, 2025
@andrewfg
Copy link
Contributor Author

Many thanks to all contributors. Many thanks to @lsiepel for merging.

phenix1990 pushed a commit to phenix1990/openhab-addons that referenced this pull request Jul 31, 2025
* [various] Add equipment tags: A thru E

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@Nadahar
Copy link
Contributor

Nadahar commented Oct 29, 2025

I'm getting a validation error when opening thing-types.xml for the Chromecast binding now, because of <semantic-equipment-tag>. When I check https://openhab.org/schemas/thing-description-1.0.0.xsd manually, it's there - however, Eclipse refuses to accept this.

My question is: Are the schemas being modified without bumping the version? Since this tag wasn't there earlier, it should no longer be 1.0.0. Doing that will cause trouble, "the rules" are that a version won't change, so they can be cached - and there might be no way to "reload" them, since they should never change. I'm guessing that is what is going on here.

Is there a reason why the version hasn't been bumped?

@andrewfg
Copy link
Contributor Author

Eclipse IDE holds a cached version of the XSD which it never seems to refresh. You need to do a global search for the XSD in your Eclipse workgroup files, and replace those files with a freshly downloaded copy from the OH web server.

@Nadahar
Copy link
Contributor

Nadahar commented Oct 30, 2025

Eclipse IDE holds a cached version of the XSD which it never seems to refresh. You need to do a global search for the XSD in your Eclipse workgroup files, and replace those files with a freshly downloaded copy from the OH web server.

Yeah, I've found the files, but my point is: Why isn't the version bumped? Eclipse is doing it correctly, like every other piece of software should. Once you have a versioned schema, it can never change, so it should never expire.

@andrewfg andrewfg deleted the equipment-tags branch December 14, 2025 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement An enhancement or new feature for an existing add-on

Projects

None yet

Development

Successfully merging this pull request may close these issues.