Bindings M thru R: Add equipment tags#18558
Conversation
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
mvalla
left a comment
There was a problem hiding this comment.
for OpenWebNet see some suggested changes. Other than those, LGTM
bundles/org.openhab.binding.openwebnet/src/main/resources/OH-INF/thing/BusThermoCentralUnit.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.openwebnet/src/main/resources/OH-INF/thing/ZBOnOffSwitch.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.openwebnet/src/main/resources/OH-INF/thing/ZBOnOffSwitch2Units.xml
Outdated
Show resolved
Hide resolved
Co-authored-by: M Valla <12682715+mvalla@users.noreply.github.com> Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Co-authored-by: M Valla <12682715+mvalla@users.noreply.github.com> Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Co-authored-by: M Valla <12682715+mvalla@users.noreply.github.com> Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
bundles/org.openhab.binding.qolsysiq/src/main/resources/OH-INF/thing/zone.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.rfxcom/src/main/resources/OH-INF/thing/chime.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.rfxcom/src/main/resources/OH-INF/thing/rain.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.rfxcom/src/main/resources/OH-INF/thing/rfy.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.rfxcom/src/main/resources/OH-INF/thing/temperaturerain.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.openwebnet/src/main/resources/OH-INF/thing/BusAlarmZone.xml
Show resolved
Hide resolved
bundles/org.openhab.binding.openwebnet/src/main/resources/OH-INF/thing/BusThermoZone.xml
Show resolved
Hide resolved
bundles/org.openhab.binding.pentair/src/main/resources/OH-INF/thing/controller.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.pilight/src/main/resources/OH-INF/thing/devices.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.pixometer/src/main/resources/OH-INF/thing/account.xml
Outdated
Show resolved
Hide resolved
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
lsiepel
left a comment
There was a problem hiding this comment.
Thanks. When the depending PR is merged, this can also be merged. LGTM
mherwege
left a comment
There was a problem hiding this comment.
LGTM for mybmw and nikohomecontrol
|
Many thanks to all contributors. Many thanks to @lsiepel for merging. |
bundles/org.openhab.binding.powermax/src/main/resources/OH-INF/thing/ip.xml
Show resolved
Hide resolved
bundles/org.openhab.binding.powermax/src/main/resources/OH-INF/thing/serial.xml
Show resolved
Hide resolved
bundles/org.openhab.binding.powermax/src/main/resources/OH-INF/thing/zone.xml
Show resolved
Hide resolved
| <bridge-type id="weather-api"> | ||
| <label>OpenWeatherMap Account</label> | ||
| <description>Provides access to the OpenWeatherMap API.</description> | ||
| <semantic-equipment-tag>WebService</semantic-equipment-tag> |
There was a problem hiding this comment.
@andrewfg : is there a logic to use WebService for the bridge (account) and WeatherService for the things?
Shouldn't we have WeatherService here also?
There was a problem hiding this comment.
Depends, if the bridge is just an account / proxy for other child Things, Webservice is fine.
If the bridge has channels and provides weather information by itself, it can be tagged WeatherService.
| <thing-type id="rcx1500"> | ||
| <label>RCX-1500 Stereo Receiver</label> | ||
| <description>Connection to the Rotel RCX-1500 stereo receiver</description> | ||
| <semantic-equipment-tag>Receiver</semantic-equipment-tag> |
There was a problem hiding this comment.
@andrewfg : can you explain what "Receiver" is for?
Is it for radio tuner?
There was a problem hiding this comment.
Receiver is the English (American) term for a typical audio visual amplifier e.g. https://europe.yamaha.com/en/products/audio_visual/av_receivers_amps/index.html -- strictly it describes an "amplifier-plus-other-features" which may include a radio tuner, but in fact includes other features like streaming, multi channel surround, dolby or other processing, video switching and pass through. In other words "receiver" has become a generic name for any a/v device. By contrast the term "amplifier" has come to mean only purist stereo amps without any other features.
There was a problem hiding this comment.
So you should have used Receiver more often for the Rotel devices (you largely used AudioVisual).
Is Receiver also adapted to a device that handles audio but not video ?
There was a problem hiding this comment.
AudioVisual is the parent of Receiver so if the thing is not self evidently the latter then it gets classified as the former.
Apropos the device that handles audio only, the same rule would apply. I.e. AudioVisual is essentially the catch all for home entertainment equipment where no more precise sub classification can clearly be applied.
There was a problem hiding this comment.
I'll add that in this list: https://github.com/openhab/openhab-core/blob/main/bundles/org.openhab.core.semantics/model/SemanticTags.csv
Receiver has the synonyms: "Receivers, Audio Receiver, Audio Receivers, AV Receiver, AV Receivers"
So it should also cover at least some devices that handle only audio?
There was a problem hiding this comment.
When updating that file, maybe also think about adding a description that makes the result of this discussion clear to future users. The description will be shown as a tooltip in the UI.
There was a problem hiding this comment.
think about adding a description
I will add that to the PR in core.. EDIT: done -- See openhab/openhab-core#4750
* Add equipment tags: M thru R Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
This PR adds Equipment tags (only) to bindings M thru R.
Signed-off-by: Andrew Fiddian-Green software@whitebear.ch
Depends on: openhab/openhab-core#4738