Skip to content

Comments

Bindings M thru R: Add equipment tags#18558

Merged
lsiepel merged 19 commits intoopenhab:mainfrom
andrewfg:equipment-tags-m-r
Apr 23, 2025
Merged

Bindings M thru R: Add equipment tags#18558
lsiepel merged 19 commits intoopenhab:mainfrom
andrewfg:equipment-tags-m-r

Conversation

@andrewfg
Copy link
Contributor

@andrewfg andrewfg commented Apr 15, 2025

This PR adds Equipment tags (only) to bindings M thru R.

  • It adds Equipment tags where it is relatively easy to determine the type of Equipment from the context.
  • It does NOT add any Point or Property tags => I am hoping that you code contributors will provide these.
  • See Equipment tags in this table for reference.

Signed-off-by: Andrew Fiddian-Green software@whitebear.ch

Depends on: openhab/openhab-core#4738

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Copy link
Contributor

@mvalla mvalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for OpenWebNet see some suggested changes. Other than those, LGTM

andrewfg and others added 4 commits April 20, 2025 00:09
Co-authored-by: M Valla <12682715+mvalla@users.noreply.github.com>
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Co-authored-by: M Valla <12682715+mvalla@users.noreply.github.com>
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Co-authored-by: M Valla <12682715+mvalla@users.noreply.github.com>
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @andrewfg. Massive! Looked at all 317 files. Have some questions, suggestions and some comments are open for discussion.

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@jlaur
Copy link
Contributor

jlaur commented Apr 22, 2025

@andrewfg - can you rebase? #18538 was merged in the meantime, so there should not be any changes for the Miele binding.

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. When the depending PR is merged, this can also be merged. LGTM

@lsiepel lsiepel added the awaiting other PR Depends on another PR label Apr 22, 2025
Copy link
Contributor

@mherwege mherwege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for mybmw and nikohomecontrol

@lsiepel lsiepel removed the awaiting other PR Depends on another PR label Apr 23, 2025
@lsiepel lsiepel merged commit 7556443 into openhab:main Apr 23, 2025
2 of 4 checks passed
@lsiepel lsiepel added this to the 5.0 milestone Apr 23, 2025
@andrewfg
Copy link
Contributor Author

Many thanks to all contributors. Many thanks to @lsiepel for merging.

<bridge-type id="weather-api">
<label>OpenWeatherMap Account</label>
<description>Provides access to the OpenWeatherMap API.</description>
<semantic-equipment-tag>WebService</semantic-equipment-tag>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrewfg : is there a logic to use WebService for the bridge (account) and WeatherService for the things?
Shouldn't we have WeatherService here also?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Depends, if the bridge is just an account / proxy for other child Things, Webservice is fine.
If the bridge has channels and provides weather information by itself, it can be tagged WeatherService.

<thing-type id="rcx1500">
<label>RCX-1500 Stereo Receiver</label>
<description>Connection to the Rotel RCX-1500 stereo receiver</description>
<semantic-equipment-tag>Receiver</semantic-equipment-tag>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrewfg : can you explain what "Receiver" is for?
Is it for radio tuner?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Receiver is the English (American) term for a typical audio visual amplifier e.g. https://europe.yamaha.com/en/products/audio_visual/av_receivers_amps/index.html -- strictly it describes an "amplifier-plus-other-features" which may include a radio tuner, but in fact includes other features like streaming, multi channel surround, dolby or other processing, video switching and pass through. In other words "receiver" has become a generic name for any a/v device. By contrast the term "amplifier" has come to mean only purist stereo amps without any other features.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So you should have used Receiver more often for the Rotel devices (you largely used AudioVisual).
Is Receiver also adapted to a device that handles audio but not video ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AudioVisual is the parent of Receiver so if the thing is not self evidently the latter then it gets classified as the former.

Apropos the device that handles audio only, the same rule would apply. I.e. AudioVisual is essentially the catch all for home entertainment equipment where no more precise sub classification can clearly be applied.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll add that in this list: https://github.com/openhab/openhab-core/blob/main/bundles/org.openhab.core.semantics/model/SemanticTags.csv

Receiver has the synonyms: "Receivers, Audio Receiver, Audio Receivers, AV Receiver, AV Receivers"

So it should also cover at least some devices that handle only audio?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When updating that file, maybe also think about adding a description that makes the result of this discussion clear to future users. The description will be shown as a tooltip in the UI.

Copy link
Contributor Author

@andrewfg andrewfg May 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

think about adding a description

I will add that to the PR in core.. EDIT: done -- See openhab/openhab-core#4750

phenix1990 pushed a commit to phenix1990/openhab-addons that referenced this pull request Jul 31, 2025
* Add equipment tags: M thru R

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@andrewfg andrewfg deleted the equipment-tags-m-r branch December 14, 2025 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement An enhancement or new feature for an existing add-on

Projects

None yet

Development

Successfully merging this pull request may close these issues.