Skip to content

Comments

Bindings S thru Z: Add equipment tags#18563

Merged
lsiepel merged 18 commits intoopenhab:mainfrom
andrewfg:equipment-tags-s-z
Apr 23, 2025
Merged

Bindings S thru Z: Add equipment tags#18563
lsiepel merged 18 commits intoopenhab:mainfrom
andrewfg:equipment-tags-s-z

Conversation

@andrewfg
Copy link
Contributor

@andrewfg andrewfg commented Apr 16, 2025 •
edited
Loading

This PR adds Equipment tags (only) to bindings S thru Z.

  • It adds Equipment tags where it is relatively easy to determine the type of Equipment from the context.
  • It does NOT add any Point or Property tags => I am hoping that you code contributors will provide these.
  • See Equipment tags in this table for reference.

Signed-off-by: Andrew Fiddian-Green software@whitebear.ch

@andrewfg
Add equipment tags: S thru Z
f3c9855 
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@andrewfg andrewfg added enhancement An enhancement or new feature for an existing add-on awaiting other PR Depends on another PR labels Apr 16, 2025
@andrewfg andrewfg self-assigned this Apr 16, 2025
andrewfg added 3 commits April 18, 2025 15:55
@andrewfg
fix siren
4c9e740 
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@andrewfg
fix smartthings
210bed4 
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@andrewfg
fix smartthings again
18b0510 
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
ccutrer
ccutrer approved these changes Apr 18, 2025
View reviewed changes
Copy link
Member

@ccutrer ccutrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for Tuya now

lsiepel
lsiepel requested changes Apr 21, 2025
View reviewed changes
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @andrewfg. I reviewed the first 163 files. Need to look at the others when i find some more time.

@andrewfg andrewfg mentioned this pull request Apr 21, 2025
Closed
@andrewfg
adopt reviwer suggestions
fb836c5 
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
lsiepel
lsiepel requested changes Apr 22, 2025
View reviewed changes
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finished the remaining files.

@andrewfg andrewfg mentioned this pull request Apr 22, 2025
Merged
@andrewfg
adopt reviewer suggestions
637c482 
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
lsiepel
lsiepel requested changes Apr 22, 2025
View reviewed changes
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One late comment. Otherwise LGTM

@andrewfg
adopt reviwer suggsetion
3786264 
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
lsiepel
lsiepel approved these changes Apr 23, 2025
View reviewed changes
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks LGTM. Covered all files. Waiting for the dependent PR

@andrewfg andrewfg added the awaiting other PR Depends on another PR label Apr 23, 2025
@JueBag
Copy link

JueBag commented Apr 23, 2025

Concerning Tankerkoenig

LGTM; Thanks

mherwege
mherwege approved these changes Apr 23, 2025
View reviewed changes
Copy link
Contributor

@mherwege mherwege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for systeminfo

@lsiepel lsiepel removed the awaiting other PR Depends on another PR label Apr 23, 2025
JueBag
JueBag approved these changes Apr 23, 2025
View reviewed changes
Copy link

@JueBag JueBag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Tankerkoenig

@lsiepel lsiepel merged commit 2093a7a into openhab:main Apr 23, 2025
2 of 4 checks passed
@lsiepel lsiepel added this to the 5.0 milestone Apr 23, 2025
@andrewfg
Copy link
Contributor Author

andrewfg commented Apr 23, 2025

Many thanks to all contributors. Many thanks to @lsiepel for merging.

@jlaur
Copy link
Contributor

jlaur commented Apr 23, 2025

@andrewfg - since the removal of the Jenkins build, the rebuild label no longer has any effect. I have triggered builds for all PR's.

Now it will have again: #18596 🙂

lolodomo
lolodomo reviewed May 10, 2025
View reviewed changes
bundles/org.openhab.binding.weatherunderground/src/main/resources/OH-INF/thing/bridge.xml
<label>Weatherunderground Bridge</label>
<description>The Weather Underground bridge represents a connection to the Weather Underground service</description>

<semantic-equipment-tag>NetworkAppliance</semantic-equipment-tag>
Copy link
Contributor

@lolodomo lolodomo May 10, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is something inconsistent.
You use NetworkAppliance for this weather service while WebService was used for the openweathermap binding.

And same question as for the openweathermap binding, shouldn't we use WeatherService instead?

Copy link
Contributor Author

@andrewfg andrewfg May 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the thing is associated with a physical local piece of equipment attached to the lan it is a network appliance. If thing is attached directly to a remote cloud based service it is a web service. And if it is a specific local widget that measures (say) temperature, humidity, barometric pressure, it is a weather station. Of course it may be that the thing may have attributes of all three of the above; in which case we need to decide which of those three is the primary and best description of that thing.

Copy link
Contributor

@lolodomo lolodomo May 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If thing is attached directly to a remote cloud based service it is a web service.

So it should be WebService here as there is no physical device, just an attachment to a remote cloud based service.

phenix1990 pushed a commit to phenix1990/openhab-addons that referenced this pull request Jul 31, 2025
@andrewfg @phenix1990
Bindings S thru Z: Add equipment tags (openhab#18563)
bfbc4e5 
* Add equipment tags: S thru Z

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@andrewfg andrewfg deleted the equipment-tags-s-z branch December 14, 2025 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lolodomo lolodomo lolodomo left review comments

@jlaur jlaur jlaur left review comments

@jsjames jsjames jsjames left review comments

@wborn wborn wborn left review comments

@clinique clinique clinique requested changes

@psmedley psmedley psmedley approved these changes

@theater theater theater approved these changes

@renescherer renescherer renescherer approved these changes

@ccutrer ccutrer ccutrer approved these changes

@lsiepel lsiepel lsiepel approved these changes

@JueBag JueBag JueBag approved these changes

@druciak druciak druciak approved these changes

@mherwege mherwege mherwege approved these changes

@pacive pacive pacive approved these changes

@mhilbush mhilbush Awaiting requested review from mhilbush mhilbush is a code owner

@claell claell Awaiting requested review from claell claell is a code owner

@zarusz zarusz Awaiting requested review from zarusz zarusz is a code owner

@coop-git coop-git Awaiting requested review from coop-git coop-git is a code owner

@Skinah Skinah Awaiting requested review from Skinah Skinah is a code owner

@marcelrv marcelrv Awaiting requested review from marcelrv marcelrv is a code owner

@hmerk hmerk Awaiting requested review from hmerk hmerk is a code owner

@jamesmelville jamesmelville Awaiting requested review from jamesmelville jamesmelville is a code owner

@Jamstah Jamstah Awaiting requested review from Jamstah Jamstah is a code owner

@miloit miloit Awaiting requested review from miloit miloit is a code owner

@steand steand Awaiting requested review from steand steand is a code owner

@dag81 dag81 Awaiting requested review from dag81 dag81 is a code owner

@jannegpriv jannegpriv Awaiting requested review from jannegpriv jannegpriv is a code owner

@t2000 t2000 Awaiting requested review from t2000 t2000 is a code owner

@MatthiasKlocke MatthiasKlocke Awaiting requested review from MatthiasKlocke MatthiasKlocke is a code owner

@bjoernbrings bjoernbrings Awaiting requested review from bjoernbrings bjoernbrings is a code owner

@GiviMAD GiviMAD Awaiting requested review from GiviMAD GiviMAD is a code owner

@mgbowman mgbowman Awaiting requested review from mgbowman mgbowman is a code owner

@Hilbrand Hilbrand Awaiting requested review from Hilbrand Hilbrand is a code owner

@J-N-K J-N-K Awaiting requested review from J-N-K J-N-K is a code owner

@cweitkamp cweitkamp Awaiting requested review from cweitkamp cweitkamp is a code owner

@kaikreuzer kaikreuzer Awaiting requested review from kaikreuzer kaikreuzer is a code owner

@olivierkeke olivierkeke Awaiting requested review from olivierkeke olivierkeke is a code owner

@roieg roieg Awaiting requested review from roieg roieg is a code owner

@kjoglum kjoglum Awaiting requested review from kjoglum kjoglum is a code owner

@kgoderis kgoderis Awaiting requested review from kgoderis kgoderis is a code owner

@nokyyz nokyyz Awaiting requested review from nokyyz nokyyz is a code owner

@mlobstein mlobstein Awaiting requested review from mlobstein mlobstein is a code owner

@digitaldan digitaldan Awaiting requested review from digitaldan digitaldan is a code owner

@MikeTheTux MikeTheTux Awaiting requested review from MikeTheTux MikeTheTux is a code owner

@chingon007 chingon007 Awaiting requested review from chingon007 chingon007 is a code owner

@octa22 octa22 Awaiting requested review from octa22 octa22 is a code owner

@BobRak BobRak Awaiting requested review from BobRak BobRak is a code owner

@msteigenberger msteigenberger Awaiting requested review from msteigenberger msteigenberger is a code owner

@monnimeter monnimeter Awaiting requested review from monnimeter monnimeter is a code owner

@syphr42 syphr42 Awaiting requested review from syphr42 syphr42 is a code owner

@chaton78 chaton78 Awaiting requested review from chaton78 chaton78 is a code owner

@markus7017 markus7017 Awaiting requested review from markus7017 markus7017 is a code owner

@MikeJMajor MikeJMajor Awaiting requested review from MikeJMajor MikeJMajor is a code owner

@weymann weymann Awaiting requested review from weymann weymann is a code owner

@seime seime Awaiting requested review from seime seime is a code owner

@hakan42 hakan42 Awaiting requested review from hakan42 hakan42 is a code owner

@nikotanghe nikotanghe Awaiting requested review from nikotanghe nikotanghe is a code owner

@vctender vctender Awaiting requested review from vctender vctender is a code owner

@itb3 itb3 Awaiting requested review from itb3 itb3 is a code owner

@tisoft tisoft Awaiting requested review from tisoft

@dougculnane dougculnane Awaiting requested review from dougculnane

@hww3 hww3 Awaiting requested review from hww3 hww3 is a code owner

@cedricboon cedricboon Awaiting requested review from cedricboon cedricboon is a code owner

@alexf2015 alexf2015 Awaiting requested review from alexf2015 alexf2015 is a code owner

Assignees

@andrewfg andrewfg

Labels

enhancement An enhancement or new feature for an existing add-on

Projects

None yet

Milestone

5.0

Development

Successfully merging this pull request may close these issues.