Merged
Conversation
* Move validation to subprojects, skip on top level to avoid double execution using a marker file (regression, openhab#18579) Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
holgerfriedrich
force-pushed
the
pr-schema-validation-2
branch
from
bd1faec to
02db3e0
Compare
holgerfriedrich
changed the title
holgerfriedrich
added
the
infrastructure
lsiepel
approved these changes
Apr 25, 2025
Contributor
lsiepel
left a comment
lsiepel
left a comment
There was a problem hiding this comment.
Thanks, LGTM.
Hopefully this would also make the builds fail less often, due to error 522 when validating the XML.
phenix1990
pushed a commit
to phenix1990/openhab-addons
that referenced
this pull request
Jul 31, 2025
* Move validation to subprojects, skip on top level to avoid double execution using a marker file (regression, openhab#18579) Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@andrewfg FYI
This finally fixes the issue mentioned in #18579 (comment).
Validation now takes place in subprojects under bundles, and is suppressed in directory bundles.
This speeds up the build and avoids that all xml files are validated in the beginning of the build and later again in each plugin.