[GHA] Permit rebuild from forks#18699
Merged
kaikreuzer merged 1 commit intoopenhab:mainfrom May 19, 2025
Merged
Conversation
Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
kaikreuzer
approved these changes
May 19, 2025
phenix1990
pushed a commit
to phenix1990/openhab-addons
that referenced
this pull request
Jul 31, 2025
Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
carryover from openhab/openhab-core#4808 - it seems it finally works fine now for core....
Rebuild still did not work on PRs from forked repost.
This is to protect the repo from malicious PRs.
The way to do it is basically, to use the
pull_request_targetinstead ofpull_request(which always runs on read-only permissions).This needs to be done carefully, see
https://securitylab.github.com/resources/github-actions-preventing-pwn-requests/
Permissions have been reduced to the necessary ones. Persistence of checkout credentials has been disabled.
Regression of
#18596
#18629
#18632