Skip to content

[ondilo] Implement review findings #18942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lsiepel merged 1 commit into from
Jul 13, 2025
Merged

[ondilo] Implement review findings #18942

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ...hab.binding.ondilo/src/main/java/org/openhab/binding/ondilo/internal/OndiloApiClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,8 +117,9 @@ private void refreshAccessTokenIfNeeded() {
if (accessTokenResponse.isExpired(Instant.now(), 120)) {
try {
this.accessTokenResponse = oAuthService.refreshToken();
if (this.accessTokenResponse != null) {
this.bearer = this.accessTokenResponse.getAccessToken();
accessTokenResponse = this.accessTokenResponse;
if (accessTokenResponse != null) {
this.bearer = accessTokenResponse.getAccessToken();
logger.trace("AccessToken renewed: {}", bearer);
}
} catch (InterruptedIOException e) {
Expand Down
6 changes: 5 additions & 1 deletion ...enhab.binding.ondilo/src/main/java/org/openhab/binding/ondilo/internal/OndiloHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
public class OndiloHandler extends BaseThingHandler {
private static final String NO_ID = "NO_ID";
private final Logger logger = LoggerFactory.getLogger(OndiloHandler.class);
private int recommendationId = 0; // Used to track the last recommendation ID processed
private int recommendationId; // Used to track the last recommendation ID processed
private AtomicReference<String> ondiloId = new AtomicReference<>(NO_ID);
private final int configPoolId;
private @Nullable ScheduledFuture<?> bridgeRecoveryJob;
Expand Down Expand Up @@ -100,6 +100,9 @@ public void handleCommand(ChannelUID channelUID, Command command) {
public void initialize() {
OndiloBridge ondiloBridge = getOndiloBridge();
if (ondiloBridge != null) {
// Initialize to 0, as no recommendation has been processed yet
recommendationId = 0;

if (configPoolId == 0) {
updateStatus(ThingStatus.OFFLINE, ThingStatusDetail.CONFIGURATION_ERROR, I18N_ID_INVALID);
return;
Expand Down Expand Up @@ -140,6 +143,7 @@ public void dispose() {
if (!ondiloId.get().equals(NO_ID)) {
ondiloId.set(NO_ID);
}
recommendationId = 0; // Reset last processed recommendation ID
}

public void clearLastMeasuresChannels() {
Expand Down
2 changes: 1 addition & 1 deletion ...hab.binding.ondilo/src/main/java/org/openhab/binding/ondilo/internal/dto/LastMeasure.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public class LastMeasure {
* {
* "data_type": "temperature",
* "value": 12.5,
* "value_time": "2020-03-23T16:08:51+0000",
* "value_time": "2025-07-13 04:33:39",
* "is_valid": true,
* "exclusion_reason": null
* }
Expand Down
6 changes: 3 additions & 3 deletions ....binding.ondilo/src/main/java/org/openhab/binding/ondilo/internal/dto/Recommendation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,10 @@ public class Recommendation {
* "id": 10251,
* "title": "Clean your filter",
* "message": "I recommend you to ...",
* "created_at": "2020-03-25T04:09:59+0000",
* "updated_at": "2020-03-25T04:09:59+0000",
* "created_at": "2025-07-13T00:32:06+0000",
* "updated_at": "2025-07-13T00:32:06.000000Z",
* "status": "waiting",
* "deadline": "2020-03-26T00:00:00+0000"
* "deadline": "2052-11-28T00:00:00.000000Z"
* }
*/

Expand Down