[ondilo] Implement review findings#18955
Merged
lsiepel merged 1 commit intoopenhab:mainfrom Jul 14, 2025
Merged
Conversation
fixed error with assignment to local instead of global variable Signed-off-by: Michael Weger <weger.michael@gmx.net>
MikeTheTux
changed the title
MikeTheTux
added
the
bug
lsiepel
added
the
regression
phenix1990
pushed a commit
to phenix1990/openhab-addons
that referenced
this pull request
Jul 31, 2025
fixed error with assignment to local instead of global variable Signed-off-by: Michael Weger <weger.michael@gmx.net>
psmedley
pushed a commit
to psmedley/openhab-addons
that referenced
this pull request
Aug 6, 2025
fixed error with assignment to local instead of global variable Signed-off-by: Michael Weger <weger.michael@gmx.net> Signed-off-by: Paul Smedley <paul@smedley.id.au>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue from #18914 (comment) was present in another location, leading so several poll-jobs running in parallel.
this PR fixes this issue and increases the buffer to 3min, as 2min still didn't catch the latest measure.