[homekit.binding] New HomeKit client binding#19340
Conversation
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
…addons into homekit-client
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
|
@ThomasM102 I think you successfully integrated your own Hue bridge via this binding? That actually was a surprise for me since my own Hue bridges (a white v2 and a black v3) did not appear in my Inbox. However on December 8th Philips/Signify announced a new firmware roll out and miracolo miracoli both of them appeared -- for a very short time -- in my Inbox :) However unfortunately before I could try to pair with them, they both equally suddenly disappeared from the Inbox again :( So I am wondering if you used some special "magic" to discover your bridges and/or to pair them? |
|
Yes, really, this takes magic (and maybe an iPhone too; I haven't tested it with Android):
This is how the discovery process worked for me with your binding. |
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Aha. The Android app doesnt even mention an Apple Home option. But fortunately I do also have an iPad so I will try that.. Is it the case that the bridge only appears in the mDNS discovery after your step 3 in the app? Also which of the two Thing Actions in the binding did you use? |
Yes, it looks like multicasting needs to be activated through the app and the hardware first. It took a lot of trial and error to find this solution. There might be an easier way, but this is how it worked for me.
I just tested both again. Everything works. Pairing works without the "With External Authentication" switch. |
jlaur
left a comment
There was a problem hiding this comment.
I had a look at your latest commits, and they LGTM. The README needs a small update after that. I had a quick look at all files changed within the last week or so, and added two ultra-minor comments.
When the README is updated, we can merge. I expect to do that sometime tomorrow (and if you are not available before then, I'll just commit that README update).
Thanks for the massive effort put into this. This is going to be a major new feature in 5.1.
...ding.homekit/src/main/java/org/openhab/binding/homekit/internal/enums/AccessoryCategory.java
Outdated
Show resolved
Hide resolved
...homekit/src/main/java/org/openhab/binding/homekit/internal/handler/HomekitBridgeHandler.java
Outdated
Show resolved
Hide resolved
This comment was marked as resolved.
This comment was marked as resolved.
Co-authored-by: Jacob Laursen <jacob-github@vindvejr.dk> Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
…binding/homekit/internal/handler/HomekitBridgeHandler.java Co-authored-by: Jacob Laursen <jacob-github@vindvejr.dk> Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
…binding/homekit/internal/enums/AccessoryCategory.java Co-authored-by: Jacob Laursen <jacob-github@vindvejr.dk> Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
|
@andrewfg if you can fix the conflicts due to the merge of other new bindings, we can finally merge this awesome contribution. |
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@lsiepel done. |
|
Thanks for all the hard work on this binding @andrewfg ! |
I think you two are right. Let's see after the snapshot build. We can always add the logo th enext week during feature freeze |
We can also replace it with a new SVG logo. It seems the logo changed over the years - is this the latest logo? If the logo will automatically be picked up as expected, we have a small issue further down the road: If we will ever have two bindings with the same name in different categories (binding/persistence/io ec.), it seems it's currently not possible to use fully qualified names and thus use different logos (if desired). Maybe fully or partially qualified names are already supported, I haven't checked, but there are no examples to prove it. 😉 |
This comment was marked as resolved.
This comment was marked as resolved.
|
Do you want me to make a PR replacing the old homekit.png with the new homekit.svg ? EDIT done here |
|
|
But we still need to merge openhab/openhab-docs#2608 |
Resolves #14094
There is an existing HomeKit system integration addon which allows exporting OH Items into the HomeKit eco- system.
This is a new HomeKit client binding addon which allows importing OH Things and Channels from the HomeKit eco- system.
There are three types of Things supported:
accessory: This integrates a single HomeKit accessory, which has its own LAN connection.Its services appear as channel groups, and their respective characteristics appear as channels.
bridged-accessory: This integrates a single HomeKit accessory, which does NOT have its own LAN connection.It has the same functionality as an
accessory, except that its communication is done via abridge(see below).bridge: This integrates a HomeKit bridge accessory, which has its own LAN connection.It does not have any own channels.
Instead it contains multiple
bridged-accessoryThings (see above).Things of type
bridgeandaccessoryboth communicate directly with their HomeKit device over the LAN. Whereasbridged-accessoryThings communicate via their respectivebridgeThing.The JAR files for testing purposes are here:
See Apple HomeKit Specification.pdf for reference.
Notes:
Signed-off-by: Andrew Fiddian-Green software@whitebear.ch
Todos (all done)
Issues that will NOT be addressed