[modbus.lambda] Initial contribution#19378
Conversation
* New translations bluetooth.properties (German) * New translations bluetooth.properties (Italian) Signed-off-by: Christian Koch <78686276+chilobo@users.noreply.github.com>
Signed-off-by: Christian Koch <78686276+chilobo@users.noreply.github.com>
e17a2c4 to
66e7b90
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new Lambda Heat Pump binding as an OpenHAB add-on to the Modbus binding, allowing integration with Lambda Heat Pumps through the Modbus TCP/IP protocol. The binding is based on the Stiebel Eltron bundle and supports various heat pump components including heat pumps, boilers, buffers, heating circuits, and solar thermic components.
- Adds complete Lambda Heat Pump binding implementation with modbus integration
- Supports multiple heat pump system components with configurable subindexes
- Includes comprehensive channel definitions for all component types
Reviewed Changes
Copilot reviewed 55 out of 55 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| bundles/pom.xml | Adds lambda module reference to parent POM |
| features/openhab-addons/src/main/resources/footer.xml | Registers lambda binding in feature bundle |
| bundles/org.openhab.binding.modbus.lambda/* | Complete binding implementation including handlers, parsers, DTOs, configurations, and XML definitions |
| bom/openhab-addons/pom.xml | Adds lambda binding dependency to BOM |
| CODEOWNERS | Assigns code ownership for lambda binding |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
...s.lambda/src/main/java/org/openhab/binding/modbus/lambda/internal/handler/BufferHandler.java
Outdated
Show resolved
Hide resolved
...s.lambda/src/main/java/org/openhab/binding/modbus/lambda/internal/handler/BoilerHandler.java
Outdated
Show resolved
Hide resolved
...s.lambda/src/main/java/org/openhab/binding/modbus/lambda/internal/handler/BoilerHandler.java
Outdated
Show resolved
Hide resolved
...us.lambda/src/main/java/org/openhab/binding/modbus/lambda/internal/LambdaHandlerFactory.java
Outdated
Show resolved
Hide resolved
...us.lambda/src/main/java/org/openhab/binding/modbus/lambda/internal/LambdaHandlerFactory.java
Outdated
Show resolved
Hide resolved
…p-20250923 Signed-off-by: Christian Koch <78686276+chilobo@users.noreply.github.com>
Signed-off-by: Christian Koch <78686276+chilobo@users.noreply.github.com>
|
Hopefully this binding can now be merged - thanks to isiepiel and hist help. |
lsiepel
left a comment
There was a problem hiding this comment.
There are about 20 build warnings that need to be fixed.
|
Build warnings:
|
Signed-off-by: Christian Koch <78686276+chilobo@users.noreply.github.com>
Signed-off-by: Christian Koch <78686276+chilobo@users.noreply.github.com>
|
@isiepel: |
No, it is unrelated to this PR. It should be fixed now. |
Signed-off-by: Christian Koch <78686276+chilobo@users.noreply.github.com>
Signed-off-by: Christian Koch <78686276+chilobo@users.noreply.github.com>
|
I had to correct errors regarding the registers >= 50 in all parts and pushed the changes. |
lsiepel
left a comment
There was a problem hiding this comment.
These comments are about fixing the last warnings and SAT errors.
...s.lambda/src/main/java/org/openhab/binding/modbus/lambda/internal/handler/BoilerHandler.java
Show resolved
Hide resolved
.../src/main/java/org/openhab/binding/modbus/lambda/internal/handler/HeatingCircuitHandler.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/openhab/binding/modbus/lambda/internal/handler/HeatingCircuitHandler.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/openhab/binding/modbus/lambda/internal/handler/HeatingCircuitHandler.java
Outdated
Show resolved
Hide resolved
...lambda/src/main/java/org/openhab/binding/modbus/lambda/internal/handler/HeatpumpHandler.java
Outdated
Show resolved
Hide resolved
...lambda/src/main/java/org/openhab/binding/modbus/lambda/internal/handler/HeatpumpHandler.java
Outdated
Show resolved
Hide resolved
...lambda/src/main/java/org/openhab/binding/modbus/lambda/internal/handler/HeatpumpHandler.java
Outdated
Show resolved
Hide resolved
...lambda/src/main/java/org/openhab/binding/modbus/lambda/internal/handler/HeatpumpHandler.java
Outdated
Show resolved
Hide resolved
...lambda/src/main/java/org/openhab/binding/modbus/lambda/internal/handler/HeatpumpHandler.java
Outdated
Show resolved
Hide resolved
...lambda/src/main/java/org/openhab/binding/modbus/lambda/internal/handler/HeatpumpHandler.java
Outdated
Show resolved
Hide resolved
…enhab/binding/modbus/lambda/internal/handler/HeatingCircuitHandler.java Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: Christian Koch <78686276+chilobo@users.noreply.github.com>
…enhab/binding/modbus/lambda/internal/handler/HeatingCircuitHandler.java Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: Christian Koch <78686276+chilobo@users.noreply.github.com>
…enhab/binding/modbus/lambda/internal/handler/HeatingCircuitHandler.java Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: Christian Koch <78686276+chilobo@users.noreply.github.com>
…enhab/binding/modbus/lambda/internal/handler/HeatpumpHandler.java Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: Christian Koch <78686276+chilobo@users.noreply.github.com>
…enhab/binding/modbus/lambda/internal/handler/HeatpumpHandler.java Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: Christian Koch <78686276+chilobo@users.noreply.github.com>
…enhab/binding/modbus/lambda/internal/handler/HeatpumpHandler.java Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: Christian Koch <78686276+chilobo@users.noreply.github.com>
…enhab/binding/modbus/lambda/internal/handler/HeatpumpHandler.java Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: Christian Koch <78686276+chilobo@users.noreply.github.com>
…enhab/binding/modbus/lambda/internal/handler/HeatpumpHandler.java Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: Christian Koch <78686276+chilobo@users.noreply.github.com>
…enhab/binding/modbus/lambda/internal/handler/HeatpumpHandler.java Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: Christian Koch <78686276+chilobo@users.noreply.github.com>
|
JFTR, about 5-6 comments are not yet addressed from the last review round. They are burried under the 'Load More' button. And the build is failing due to a missing import. |
…enhab/binding/modbus/lambda/internal/handler/HeatpumpHandler.java Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: Christian Koch <78686276+chilobo@users.noreply.github.com>
…enhab/binding/modbus/lambda/internal/handler/SolarHandler.java Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: Christian Koch <78686276+chilobo@users.noreply.github.com>
…enhab/binding/modbus/lambda/internal/handler/SolarHandler.java Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: Christian Koch <78686276+chilobo@users.noreply.github.com>
…enhab/binding/modbus/lambda/internal/parser/BoilerReg50BlockParser.java Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: Christian Koch <78686276+chilobo@users.noreply.github.com>
…enhab/binding/modbus/lambda/internal/handler/HeatpumpHandler.java Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: Christian Koch <78686276+chilobo@users.noreply.github.com>
…enhab/binding/modbus/lambda/internal/handler/HeatpumpHandler.java Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: Christian Koch <78686276+chilobo@users.noreply.github.com>
|
These missing imports are caused by the changes you suggested: |
|
Signed-off-by: Christian Koch <78686276+chilobo@users.noreply.github.com>
|
I added the code in all occurences of myconfig = .... |
lsiepel
left a comment
There was a problem hiding this comment.
Thanks, LGTM.
Now, you could add the binding's logo to the openHAB website. See https://www.openhab.org/docs/developer/addons/#add-your-add-on-s-logo-to-the-openhab-website
(waiting for the build to finish.
|
I asked the support of Lambda if it is allowed to use their Logo... |
...g.modbus.lambda/src/main/java/org/openhab/binding/modbus/lambda/internal/dto/SolarBlock.java
Outdated
Show resolved
Hide resolved
…enhab/binding/modbus/lambda/internal/dto/SolarBlock.java Signed-off-by: Johannes Koch <github@lockhead.net>
... and they send me several logos. I added one of them in In the Documentation it says:
We'll see how to add the link to the merged pull request of the binding .... |
|
@isiepel: Could you point me to some explanation: How do I connect the binding to the Icon in |
|
@kaikreuzer can you add @chilobo to the contributor group ? |
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/openhab-5-1-release-discussion/167620/261 |
Based on the Stiebel Eltron bundle by Paul Frank I contribute a bundle to manage Lambda Heat Pumps as a OSG addon to the Modbus Binding.
See the README.md for restrictions on usage.
The binding is based on the Modbus description of the manufacturer:
(https://lambda-wp.at/wp-content/uploads/2025/04/Modbus-Beschreibung-und-Protokoll.pdf)
A few parts of the description are not implemented. If you feel you need them, just open a request.
Fixed all feedback from #18330 and closed old PR due to Signoff/Rebase issues
Edit: Supersedes: #18330