Skip to content

Comments

[modbus.lambda] Initial contribution#19378

Merged
lsiepel merged 25 commits intoopenhab:mainfrom
chilobo:modbus-lambda-heatpump-20250923
Nov 23, 2025
Merged

[modbus.lambda] Initial contribution#19378
lsiepel merged 25 commits intoopenhab:mainfrom
chilobo:modbus-lambda-heatpump-20250923

Conversation

@chilobo
Copy link
Contributor

@chilobo chilobo commented Sep 23, 2025

Based on the Stiebel Eltron bundle by Paul Frank I contribute a bundle to manage Lambda Heat Pumps as a OSG addon to the Modbus Binding.

See the README.md for restrictions on usage.

The binding is based on the Modbus description of the manufacturer:
(https://lambda-wp.at/wp-content/uploads/2025/04/Modbus-Beschreibung-und-Protokoll.pdf)
A few parts of the description are not implemented. If you feel you need them, just open a request.

Fixed all feedback from #18330 and closed old PR due to Signoff/Rebase issues

Edit: Supersedes: #18330

@chilobo chilobo requested a review from a team as a code owner September 23, 2025 07:22
openhab-bot and others added 2 commits September 23, 2025 09:38
* New translations bluetooth.properties (German)
* New translations bluetooth.properties (Italian)

Signed-off-by: Christian Koch <78686276+chilobo@users.noreply.github.com>
Signed-off-by: Christian Koch <78686276+chilobo@users.noreply.github.com>
@chilobo chilobo force-pushed the modbus-lambda-heatpump-20250923 branch from e17a2c4 to 66e7b90 Compare September 23, 2025 07:38
@lsiepel lsiepel changed the title Updated and signed off version of Lambda Heat Pump [modbus.lambda] Initial contribution Sep 23, 2025
@lsiepel lsiepel added the new binding If someone has started to work on a binding. For a new binding PR. label Sep 23, 2025
@wborn wborn requested a review from Copilot September 24, 2025 05:44
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new Lambda Heat Pump binding as an OpenHAB add-on to the Modbus binding, allowing integration with Lambda Heat Pumps through the Modbus TCP/IP protocol. The binding is based on the Stiebel Eltron bundle and supports various heat pump components including heat pumps, boilers, buffers, heating circuits, and solar thermic components.

  • Adds complete Lambda Heat Pump binding implementation with modbus integration
  • Supports multiple heat pump system components with configurable subindexes
  • Includes comprehensive channel definitions for all component types

Reviewed Changes

Copilot reviewed 55 out of 55 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
bundles/pom.xml Adds lambda module reference to parent POM
features/openhab-addons/src/main/resources/footer.xml Registers lambda binding in feature bundle
bundles/org.openhab.binding.modbus.lambda/* Complete binding implementation including handlers, parsers, DTOs, configurations, and XML definitions
bom/openhab-addons/pom.xml Adds lambda binding dependency to BOM
CODEOWNERS Assigns code ownership for lambda binding

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

…p-20250923

Signed-off-by: Christian Koch <78686276+chilobo@users.noreply.github.com>
Signed-off-by: Christian Koch <78686276+chilobo@users.noreply.github.com>
@chilobo
Copy link
Contributor Author

chilobo commented Sep 25, 2025

Hopefully this binding can now be merged - thanks to isiepiel and hist help.

Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are about 20 build warnings that need to be fixed.

@chilobo
Copy link
Contributor Author

chilobo commented Sep 28, 2025

Build warnings:
There are only 4 types of warnings:

  1. Potential null pointer access: The variable myconfig may be null at this location:
    The parent OSGI-bundle of modbus is using the same code, so if somebody fixes this there I will copy it.

  2. Type safety: The method toUnit(javax.measure.Unit) belongs to the raw type org.openhab.core.library.types.QuantityType. References to generic type org.openhab.core.library.types.QuantityType should be parameterized:
    I copied this from the stiebeleltron bundle. I am not capable of fixinig it.

  3. getInt16Value(org.openhab.core.types.Command) from the type ... is never used locally:
    I changed this code into a comment because I might have to use it if Lambda adds values to these sections in the future

  4. The value of the field *.AbstractBasePoller.logger is not used:
    I added a logger.trace to show that the corresponding poller is initiated and delete the unused loggers.

Signed-off-by: Christian Koch <78686276+chilobo@users.noreply.github.com>
Signed-off-by: Christian Koch <78686276+chilobo@users.noreply.github.com>
@chilobo
Copy link
Contributor Author

chilobo commented Oct 1, 2025

@isiepel:
Could you look into
https://github.com/openhab/openhab-addons/actions/runs/18137231967/job/51619015639#step:8:2255
The build shows an error with openhab-addons/openhab-addons/bundles/org.openhab.binding.mqtt
Do you think I messed something up after merging openhab/main or has somebody else has to clean this before the build with my binding will go through?

@lsiepel
Copy link
Contributor

lsiepel commented Oct 1, 2025

Do you think I messed something up..

No, it is unrelated to this PR. It should be fixed now.

@lsiepel lsiepel added the rebuild Triggers Jenkins PR build label Oct 20, 2025
@github-actions github-actions bot removed the rebuild Triggers Jenkins PR build label Oct 20, 2025
Signed-off-by: Christian Koch <78686276+chilobo@users.noreply.github.com>
Signed-off-by: Christian Koch <78686276+chilobo@users.noreply.github.com>
@chilobo
Copy link
Contributor Author

chilobo commented Oct 29, 2025

I had to correct errors regarding the registers >= 50 in all parts and pushed the changes.

Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These comments are about fixing the last warnings and SAT errors.

chilobo and others added 4 commits November 2, 2025 09:42
…enhab/binding/modbus/lambda/internal/handler/HeatingCircuitHandler.java

Co-authored-by: lsiepel <leosiepel@gmail.com>
Signed-off-by: Christian Koch <78686276+chilobo@users.noreply.github.com>
…enhab/binding/modbus/lambda/internal/handler/HeatingCircuitHandler.java

Co-authored-by: lsiepel <leosiepel@gmail.com>
Signed-off-by: Christian Koch <78686276+chilobo@users.noreply.github.com>
…enhab/binding/modbus/lambda/internal/handler/HeatingCircuitHandler.java

Co-authored-by: lsiepel <leosiepel@gmail.com>
Signed-off-by: Christian Koch <78686276+chilobo@users.noreply.github.com>
…enhab/binding/modbus/lambda/internal/handler/HeatpumpHandler.java

Co-authored-by: lsiepel <leosiepel@gmail.com>
Signed-off-by: Christian Koch <78686276+chilobo@users.noreply.github.com>
chilobo and others added 5 commits November 2, 2025 09:44
…enhab/binding/modbus/lambda/internal/handler/HeatpumpHandler.java

Co-authored-by: lsiepel <leosiepel@gmail.com>
Signed-off-by: Christian Koch <78686276+chilobo@users.noreply.github.com>
…enhab/binding/modbus/lambda/internal/handler/HeatpumpHandler.java

Co-authored-by: lsiepel <leosiepel@gmail.com>
Signed-off-by: Christian Koch <78686276+chilobo@users.noreply.github.com>
…enhab/binding/modbus/lambda/internal/handler/HeatpumpHandler.java

Co-authored-by: lsiepel <leosiepel@gmail.com>
Signed-off-by: Christian Koch <78686276+chilobo@users.noreply.github.com>
…enhab/binding/modbus/lambda/internal/handler/HeatpumpHandler.java

Co-authored-by: lsiepel <leosiepel@gmail.com>
Signed-off-by: Christian Koch <78686276+chilobo@users.noreply.github.com>
…enhab/binding/modbus/lambda/internal/handler/HeatpumpHandler.java

Co-authored-by: lsiepel <leosiepel@gmail.com>
Signed-off-by: Christian Koch <78686276+chilobo@users.noreply.github.com>
@lsiepel
Copy link
Contributor

lsiepel commented Nov 5, 2025

JFTR, about 5-6 comments are not yet addressed from the last review round. They are burried under the 'Load More' button.

And the build is failing due to a missing import.

chilobo and others added 6 commits November 6, 2025 09:25
…enhab/binding/modbus/lambda/internal/handler/HeatpumpHandler.java

Co-authored-by: lsiepel <leosiepel@gmail.com>
Signed-off-by: Christian Koch <78686276+chilobo@users.noreply.github.com>
…enhab/binding/modbus/lambda/internal/handler/SolarHandler.java

Co-authored-by: lsiepel <leosiepel@gmail.com>
Signed-off-by: Christian Koch <78686276+chilobo@users.noreply.github.com>
…enhab/binding/modbus/lambda/internal/handler/SolarHandler.java

Co-authored-by: lsiepel <leosiepel@gmail.com>
Signed-off-by: Christian Koch <78686276+chilobo@users.noreply.github.com>
…enhab/binding/modbus/lambda/internal/parser/BoilerReg50BlockParser.java

Co-authored-by: lsiepel <leosiepel@gmail.com>
Signed-off-by: Christian Koch <78686276+chilobo@users.noreply.github.com>
…enhab/binding/modbus/lambda/internal/handler/HeatpumpHandler.java

Co-authored-by: lsiepel <leosiepel@gmail.com>
Signed-off-by: Christian Koch <78686276+chilobo@users.noreply.github.com>
…enhab/binding/modbus/lambda/internal/handler/HeatpumpHandler.java

Co-authored-by: lsiepel <leosiepel@gmail.com>
Signed-off-by: Christian Koch <78686276+chilobo@users.noreply.github.com>
@chilobo
Copy link
Contributor Author

chilobo commented Nov 6, 2025

These missing imports are caused by the changes you suggested:
Objects.requireNonNull
What do I have to import?
You suggested these changes in only three handlers. Should I change them in the other ones too?

@lsiepel
Copy link
Contributor

lsiepel commented Nov 6, 2025

Objects.requireNonNull

import java.util.Objects; just for the files that use the Objects.require....

Signed-off-by: Christian Koch <78686276+chilobo@users.noreply.github.com>
@chilobo
Copy link
Contributor Author

chilobo commented Nov 6, 2025

I added the code in all occurences of myconfig = ....

Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.

Now, you could add the binding's logo to the openHAB website. See https://www.openhab.org/docs/developer/addons/#add-your-add-on-s-logo-to-the-openhab-website

(waiting for the build to finish.

@chilobo
Copy link
Contributor Author

chilobo commented Nov 6, 2025

I asked the support of Lambda if it is allowed to use their Logo...

…enhab/binding/modbus/lambda/internal/dto/SolarBlock.java

Signed-off-by: Johannes Koch <github@lockhead.net>
@chilobo
Copy link
Contributor Author

chilobo commented Nov 10, 2025

I asked the support of Lambda if it is allowed to use their Logo...

... and they send me several logos. I added one of them in
https://github.com/openhab/openhab-docs/pull/2593
This pull request went through but ....

In the Documentation it says:

After your binding's pull request has been merged, you can upload your logo by filing another pull request to the openhab-docs/images/addons/ (opens new window) repository. Your logo will be available after the next website build.

We'll see how to add the link to the merged pull request of the binding ....

@lsiepel lsiepel merged commit e393064 into openhab:main Nov 23, 2025
2 checks passed
@lsiepel lsiepel added this to the 5.1 milestone Nov 23, 2025
@chilobo
Copy link
Contributor Author

chilobo commented Nov 24, 2025

@isiepel: Could you point me to some explanation: How do I connect the binding to the Icon in
https://github.com/openhab/openhab-docs/pull/2593

@lewie
Copy link

lewie commented Dec 9, 2025

Hello @lsiepel, I have registered you for this minor change for review. I hope that was correct.
Many thanks.
#19749

@lsiepel
Copy link
Contributor

lsiepel commented Dec 9, 2025

@kaikreuzer can you add @chilobo to the contributor group ?

@chilobo
Copy link
Contributor Author

chilobo commented Dec 19, 2025

Added handling of swapped DWords of VdaE and VdaQ in some heat pumps
as mentioned in
(#19749)
with a new pull request
(#19835)

@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/openhab-5-1-release-discussion/167620/261

@jlaur jlaur mentioned this pull request Feb 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new binding If someone has started to work on a binding. For a new binding PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants