[matter] Add support for door lock bolting (EU style locks)#19386
[matter] Add support for door lock bolting (EU style locks)#19386lsiepel merged 7 commits intoopenhab:mainfrom
Conversation
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for door lock bolting functionality to the Matter binding, specifically targeting EU-style locks that support both latching and bolting operations. The changes introduce a new channel for bolt state control and modify the existing lock state behavior to differentiate between latched and bolted states when the unbolting feature is available.
- Adds a new
doorlock-boltstatechannel for controlling the bolt state of EU-style door locks - Updates the existing
doorlock-lockstatechannel to represent latch state when unbolting is supported - Implements proper state mapping for different lock states (LOCKED, UNLOCKED, UNLATCHED, NOT_FULLY_LOCKED)
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| DoorLockConverter.java | Core implementation adding bolt channel support and state mapping logic |
| DoorLockConverterTest.java | Comprehensive test coverage for new bolt functionality and state transitions |
| MatterBindingConstants.java | Added constants for the new bolt state channel |
| channels.xml | Added new bolt state channel type definition |
| matter.properties | Added internationalization strings for bolt state channel |
| README.md | Updated documentation to reflect the new bolt state channel |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
.../org/openhab/binding/matter/internal/controller/devices/converter/DoorLockConverterTest.java
Outdated
Show resolved
Hide resolved
...java/org/openhab/binding/matter/internal/controller/devices/converter/DoorLockConverter.java
Outdated
Show resolved
Hide resolved
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: |
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Dan Cunningham <dan@digitaldan.com>
jlaur
changed the title
lolodomo
added
the
enhancement
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/nuki-binding-with-new-smart-lock-ultra-pro-go/166635/15 |
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: |
- Resolved conflicts in MatterBindingConstants.java by including both the new bolt state channel and the additional channels from main (doorstate, alarm, lockoperationerror) - Resolved conflicts in matter.properties by including all channel type descriptions - Resolved conflicts in DoorLockConverter.java by integrating bolt state functionality into the more advanced version from main that includes user management and PIN code features - Updated DoorLockConverter to support unbolting feature with proper lock state handling (LOCKED, UNLOCKED, UNLATCHED, NOT_FULLY_LOCKED) - Took main version of DoorLockConverterTest.java as it matches the implementation - Added doorlock-boltstate channel to README.md table and updated lockstate description
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
|
This one is ready for review, thanks! |
lsiepel
left a comment
lsiepel
left a comment
There was a problem hiding this comment.
Just one comment, otherwise LGTM
bundles/org.openhab.binding.matter/src/main/resources/OH-INF/thing/channels.xml
Outdated
Show resolved
Hide resolved
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
|
Thanks! |
|
This one fell of my radar, could you resolve the conflict ? |
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
|
Me too! Updated, thanks. |
4 participants
No description provided.