[solarman] Add ability to write to Solarman registers#19408
Closed
san4esmc wants to merge 2 commits intoopenhab:5.0.xfrom
Closed
[solarman] Add ability to write to Solarman registers#19408san4esmc wants to merge 2 commits intoopenhab:5.0.xfrom
san4esmc wants to merge 2 commits intoopenhab:5.0.xfrom
Conversation
Signed-off-by: Oleksandr Mishchuk <olexandr.mishchuk@gmail.com>
Collaborator
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: |
jlaur
changed the title
Contributor
|
@san4esmc - thanks for your contribution. Please retarget your PR towards the main branch and fix your sign-off. |
san4esmc
requested review from
a team,
BjoernLange,
FlorianSW,
GiviMAD,
J-N-K,
antroids,
clinique,
cweitkamp,
dalgwen,
gbicskei,
jlaur,
jochen314,
jsjames,
kaikreuzer,
lolodomo,
lujop,
marcelrv,
mherwege,
morph166955,
paulianttila,
pravussum,
ssalonen and
wborn
as code owners
san4esmc
requested review from
BobRak,
Confectrician,
MikeJMajor,
Stratehm,
appzer,
chaton78,
crnjan,
dougculnane,
druciak,
hakan42,
itb3,
jeremystucki,
markus7017,
martinvw,
monnimeter,
msteigenberger,
nikotanghe,
nils,
pacive,
peuter,
ramack,
reyem,
seime,
stefanroellin,
syphr42 and
vctender
as code owners
Contributor
Author
I will create new PR - seems like simple change of target branch will not work here |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[solarman] Add ability to write to Solarman registers
Description
Current binding implementation doesn't allow to change data in invertor - only reads data from it. At the same time there are sets of registers that can safely be manipulated to automate eletricity usage, etc.
By default all registers are treated as read-only unless other is directly stated in channel configuration, which should avoid any accidental writes.
To make channel writable you should add
readOnly=falseto channel configuration. I have also added one new invertor definitiondeye_sg01hp3for Deye 30KWh High Volatage inverter, where this was tested. New channels introduced there are connected to Time Of Use functionality, including time periods, battery SOC, charge enabled.Testing
Existing unit tests were adapted to refactored code.
To test updated binding you can download built jar here: https://mega.nz/file/jjAlAT4D#mFLoSH1T8NP36iZzJKroslgVaMFkOTtW1ve7hfJ7KnY