[mqtt.awtrix3] Allow blink/fade colored text and make text effects more user friendly#19474
Merged
lsiepel merged 2 commits intoopenhab:mainfrom Oct 17, 2025
Merged
[mqtt.awtrix3] Allow blink/fade colored text and make text effects more user friendly#19474lsiepel merged 2 commits intoopenhab:mainfrom
lsiepel merged 2 commits intoopenhab:mainfrom
Conversation
…e user friendly Signed-off-by: Thomas Lauterbach <2452988+DrRSatzteil@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR relaxes text effect limitations and changes effect precedence to make rainbow easier to toggle while allowing blink/fade with colored text segments.
- Allow blink/fade to work with colored text (including segment-colored via font tags)
- Change precedence so rainbow overrides color/gradient/blink/fade (but is ignored when text has color tags)
- Update tests and README to reflect new behavior and correct channel types/usability notes
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| bundles/org.openhab.binding.mqtt.awtrixlight/src/main/java/org/openhab/binding/mqtt/awtrixlight/internal/app/AwtrixApp.java | Implements new effect precedence and allows blink/fade with color tags; adjusts color config when rainbow is enabled. |
| bundles/org.openhab.binding.mqtt.awtrixlight/src/test/java/org/openhab/binding/mqtt/awtrixlight/internal/HelperTest.java | Updates tests to assert rainbow overrides fade and copy semantics accordingly. |
| bundles/org.openhab.binding.mqtt.awtrixlight/README.md | Documents new precedence rules, fixes channel type for top-text, and updates examples. |
Comments suppressed due to low confidence (1)
bundles/org.openhab.binding.mqtt.awtrixlight/README.md:1
- Fix extra space in 'is set'.
# MQTT Awtrix 3 Binding
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
...t.awtrixlight/src/main/java/org/openhab/binding/mqtt/awtrixlight/internal/app/AwtrixApp.java
Show resolved
Hide resolved
Signed-off-by: Thomas Lauterbach <2452988+DrRSatzteil@users.noreply.github.com>
d41dad1 to
2629286
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does two things:
In addition to that this PR also fixes the README, because it was not correct about the order of overrides.