[nikohomecontrol] Add electricity meters and car chargers#19477
Merged
lsiepel merged 13 commits intoopenhab:mainfrom Oct 20, 2025
Merged
[nikohomecontrol] Add electricity meters and car chargers#19477lsiepel merged 13 commits intoopenhab:mainfrom
lsiepel merged 13 commits intoopenhab:mainfrom
Conversation
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive support for car chargers and improved energy metering for Niko Home Control II binding. The purpose is to extend the binding's functionality to control car chargers and provide more detailed energy monitoring capabilities.
Key changes:
- Add complete car charger support with status, charging mode control, and energy metering
- Enhance energy metering with support for home digital meters including grid import/export and self-consumption tracking
- Add HTTP client integration for retrieving meter measurements from the controller
Reviewed Changes
Copilot reviewed 30 out of 30 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| thing-types.xml | Defines new energyMeterHome and carCharger thing types with their channels and configuration parameters |
| nikohomecontrol.properties | Adds internationalization strings for new car charger and enhanced energy meter functionality |
| NikoHomeControlCommunication2.java | Implements car charger device handling, HTTP meter reading support, and enhanced energy meter state updates |
| NhcMqttConnection2.java | Refactors SSL context creation to use shared SslContextProvider |
| NhcMeterReading2.java | New class for parsing HTTP meter reading responses |
| NhcMeter2.java | Enhanced meter implementation supporting multiple readings and improved state management |
| NhcHttpConnection2.java | New HTTP client for retrieving meter measurements from the controller |
| NhcDevice2.java | Extended device properties to support car charger and enhanced meter fields |
| NhcCarCharger2.java | Niko Home Control II car charger implementation |
| NikoHomeControlCommunication1.java | Updated meter execution method signature for consistency |
| NhcMeter1.java | Enhanced meter implementation with improved reading methods |
| NikoHomeControlConstants.java | Added constants for car charger states, charging modes, and energy measurement types |
| Multiple handler and configuration files | Support for new car charger thing type and enhanced meter functionality |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
...rg.openhab.binding.nikohomecontrol/src/main/resources/OH-INF/i18n/nikohomecontrol.properties
Outdated
Show resolved
Hide resolved
...ntrol/src/main/java/org/openhab/binding/nikohomecontrol/internal/protocol/NhcMeterEvent.java
Outdated
Show resolved
Hide resolved
...a/org/openhab/binding/nikohomecontrol/internal/handler/NikoHomeControlCarChargerHandler.java
Outdated
Show resolved
Hide resolved
...ntrol/src/main/java/org/openhab/binding/nikohomecontrol/internal/protocol/NhcMeterEvent.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
lsiepel
requested changes
Oct 17, 2025
.../main/java/org/openhab/binding/nikohomecontrol/internal/NikoHomeControlBindingConstants.java
Show resolved
Hide resolved
...a/org/openhab/binding/nikohomecontrol/internal/handler/NikoHomeControlCarChargerHandler.java
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.nikohomecontrol/src/main/resources/OH-INF/thing/thing-types.xml
Show resolved
Hide resolved
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extends the Niko Home Control binding with following functions for Niko Home Control II:
All energy metering has 2 channels: