Skip to content

[upnpcontrol] Missing TrackMetaData keys in onValueReceived switch case #19485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lsiepel merged 3 commits into from
Oct 17, 2025
Merged

[upnpcontrol] Missing TrackMetaData keys in onValueReceived switch case #19485

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
06c5416
missing TrackMetaData keys in onValueReceived switch case
lo92fr Oct 15, 2025
df32430
add @lsiepel sugested comment
lo92fr Oct 17, 2025
4bfafaa
spotless:apply
lo92fr Oct 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...l/src/main/java/org/openhab/binding/upnpcontrol/internal/handler/UpnpRendererHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1086,6 +1086,7 @@ public void onValueReceived(@Nullable String variable, @Nullable String value, @
break;
case "CurrentTrackMetaData":
case "CurrentURIMetaData":
case "TrackMetaData":
onValueReceivedCurrentMetaData(value);
break;
case "NextAVTransportURIMetaData":
Comment on lines 1086 to 1093
Copy link

Copilot AI Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] TrackMetaData appears to be a vendor-specific variant; consider adding a brief inline comment to document why this additional key is handled here (e.g., 'Some renderers emit TrackMetaData instead of CurrentTrackMetaData/CurrentURIMetaData'). This will help future maintainers avoid removing it as redundant.

Copilot uses AI. Check for mistakes.
Copy link
Contributor

@lsiepel lsiepel Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
break;
case "CurrentTrackMetaData":
case "CurrentURIMetaData":
case "TrackMetaData":
onValueReceivedCurrentMetaData(value);
break;
case "NextAVTransportURIMetaData":
break;
case "CurrentTrackMetaData":
case "CurrentURIMetaData":
case "TrackMetaData": // Some (non-compliant) renderers emit TrackMetaData instead of CurrentTrackMetaData/CurrentURIMetaData
onValueReceivedCurrentMetaData(value);
break;
case "NextAVTransportURIMetaData":

Copy link
Contributor Author

@lo92fr lo92fr Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Expand Down