[homeassistant] Fix re-connection after connection loss#19491
Merged
lsiepel merged 1 commit intoopenhab:mainfrom Oct 17, 2025
Merged
[homeassistant] Fix re-connection after connection loss#19491lsiepel merged 1 commit intoopenhab:mainfrom
lsiepel merged 1 commit intoopenhab:mainfrom
Conversation
A connection loss only goes through a `stop`/start cycle, not a `dispose`/`initialize` cycle. `discoveryHomeAssistantIDs` (the list of discovery topics to subscribe to) only gets populated in `initialize`, so don't clear it in `stop` -- only in `dispose`. This means that after a reconnect, it had forgetten which topics it needed to subscribe to. Signed-off-by: Cody Cutrer <cody@cutrer.us>
Member
Author
|
Given the triviality of this fix, and how annoying it can be for some users with even moderately flakey connections to their MQTT broker, this seems like a reasonable thing to back port to 5.0 if we think we'll have another release in that line. |
Collaborator
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: |
lsiepel
pushed a commit
that referenced
this pull request
Oct 17, 2025
A connection loss only goes through a `stop`/start cycle, not a `dispose`/`initialize` cycle. Signed-off-by: Cody Cutrer <cody@cutrer.us>
lsiepel
added
the
backported
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A connection loss only goes through a
stop/start cycle, not adispose/initializecycle.discoveryHomeAssistantIDs(the list of discovery topics to subscribe to) only gets populated ininitialize, so don't clear it instop-- only indispose.This means that after a reconnect, it had forgetten which topics it needed to subscribe to.
Fixes #19431