[remehaheating] Initial contribution#19494
Conversation
Add binding for Remeha Home heating systems. Supports monitoring and control of Remeha boilers connected to the Remeha cloud service. Features: - Temperature monitoring and control - Hot water (DHW) management - System status monitoring - OAuth2 PKCE authentication Signed-off-by: Michael Fraedrich <it-services@freddy4u.de>
Signed-off-by: Michael Fraedrich <it-services@freddy4u.de>
lsiepel
left a comment
There was a problem hiding this comment.
Thansk for contributing this binding. I had a quick initial look. The comments can be applied on multiple lines, so hopefully you can fix all places it occurs.
Readme, handler and apiclient are the three files i have not yet looked at.
.../src/main/java/org/openhab/binding/remehaheating/internal/RemehaHeatingBindingConstants.java
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.remehaheating/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.remehaheating/src/main/resources/OH-INF/thing/thing-types.xml
Show resolved
Hide resolved
bundles/org.openhab.binding.remehaheating/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.remehaheating/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
…nsistency Signed-off-by: Michael Fraedrich <it-services@freddy4u.de>
1d62fd4 to
fd7e987
Compare
bundles/org.openhab.binding.remehaheating/src/main/resources/OH-INF/thing/thing-types.xml
Show resolved
Hide resolved
.../src/main/java/org/openhab/binding/remehaheating/internal/RemehaHeatingBindingConstants.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull Request Overview
Initial contribution of the Remeha Heating binding integrating Remeha Home cloud-connected boilers into openHAB with monitoring and basic control.
- Adds new binding, handler, handler factory, and API client with OAuth2 PKCE flow
- Defines thing types, channels, i18n, feature, and tests
Reviewed Changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated 11 comments.
Show a summary per file
| File | Description |
|---|---|
| bundles/pom.xml | Registers new remehaheating module in build |
| bom/openhab-addons/pom.xml | Adds binding to BOM dependencies |
| CODEOWNERS | Assigns ownership for new bundle |
| bundles/org.openhab.binding.remehaheating/pom.xml | New bundle POM |
| bundles/org.openhab.binding.remehaheating/src/main/java/.../RemehaApiClient.java | Implements OAuth2 PKCE and API calls |
| bundles/org.openhab.binding.remehaheating/src/main/java/.../RemehaHeatingHandler.java | Thing handler logic, polling, updates, and commands |
| bundles/org.openhab.binding.remehaheating/src/main/java/.../RemehaHeatingHandlerFactory.java | OSGi factory for handler |
| bundles/org.openhab.binding.remehaheating/src/main/java/.../RemehaHeatingBindingConstants.java | Binding constants |
| bundles/org.openhab.binding.remehaheating/src/main/java/.../RemehaHeatingConfiguration.java | Thing configuration class |
| bundles/org.openhab.binding.remehaheating/src/main/resources/OH-INF/thing/thing-types.xml | Thing and channel types |
| bundles/org.openhab.binding.remehaheating/src/main/resources/OH-INF/i18n/remehaheating.properties | I18n labels/descriptions |
| bundles/org.openhab.binding.remehaheating/src/main/resources/OH-INF/addon/addon.xml | Add-on metadata |
| bundles/org.openhab.binding.remehaheating/src/main/feature/feature.xml | Karaf feature definition |
| bundles/org.openhab.binding.remehaheating/README.md | Binding documentation |
| tests and sample JSON | Unit tests and test resource |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
.../test/java/org/openhab/binding/remehaheating/internal/RemehaHeatingBindingConstantsTest.java
Outdated
Show resolved
Hide resolved
...es/org.openhab.binding.remehaheating/src/main/resources/OH-INF/i18n/remehaheating.properties
Outdated
Show resolved
Hide resolved
...es/org.openhab.binding.remehaheating/src/main/resources/OH-INF/i18n/remehaheating.properties
Outdated
Show resolved
Hide resolved
....remehaheating/src/main/java/org/openhab/binding/remehaheating/internal/RemehaApiClient.java
Outdated
Show resolved
Hide resolved
...haheating/src/main/java/org/openhab/binding/remehaheating/internal/RemehaHeatingHandler.java
Outdated
Show resolved
Hide resolved
....remehaheating/src/main/java/org/openhab/binding/remehaheating/internal/RemehaApiClient.java
Outdated
Show resolved
Hide resolved
....remehaheating/src/main/java/org/openhab/binding/remehaheating/internal/RemehaApiClient.java
Outdated
Show resolved
Hide resolved
....remehaheating/src/main/java/org/openhab/binding/remehaheating/internal/RemehaApiClient.java
Outdated
Show resolved
Hide resolved
...ehaheating/src/test/java/org/openhab/binding/remehaheating/internal/RemehaApiClientTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Michael Fraedrich <it-services@freddy4u.de>
Signed-off-by: Michael Fraedrich <it-services@freddy4u.de>
|
Are you able to proceed @FreddyFFM ? |
Sure, what is still open from you side? Did I miss something? |
|
Ah, i see. Usually one comments or addss a thumbs up icon when a comment is being processed. But now i see all was addressed already. only #19494 (comment) left. |
lsiepel
left a comment
There was a problem hiding this comment.
Thansk, Looked at all the files. Some comments are left. I think this PR is pretty clean already. Mainly the handler and the apiclient need some attention.
Minor suggestion: You could create a seperate folder api next to the handler, and add the apiclient and future dto's and whatever is needed into that package.
Don;t forget to:
- fix all warnings and SAT
- regenerate i18n file if not already.
...haheating/src/main/java/org/openhab/binding/remehaheating/internal/RemehaHeatingHandler.java
Outdated
Show resolved
Hide resolved
...haheating/src/main/java/org/openhab/binding/remehaheating/internal/RemehaHeatingHandler.java
Outdated
Show resolved
Hide resolved
...ng/src/main/java/org/openhab/binding/remehaheating/internal/RemehaHeatingHandlerFactory.java
Outdated
Show resolved
Hide resolved
....remehaheating/src/main/java/org/openhab/binding/remehaheating/internal/RemehaApiClient.java
Outdated
Show resolved
Hide resolved
...ehaheating/src/main/java/org/openhab/binding/remehaheating/internal/api/RemehaApiClient.java
Show resolved
Hide resolved
...ehaheating/src/main/java/org/openhab/binding/remehaheating/internal/api/RemehaApiClient.java
Show resolved
Hide resolved
....remehaheating/src/main/java/org/openhab/binding/remehaheating/internal/RemehaApiClient.java
Outdated
Show resolved
Hide resolved
...haheating/src/main/java/org/openhab/binding/remehaheating/internal/RemehaHeatingHandler.java
Outdated
Show resolved
Hide resolved
...haheating/src/main/java/org/openhab/binding/remehaheating/internal/RemehaHeatingHandler.java
Outdated
Show resolved
Hide resolved
...haheating/src/main/java/org/openhab/binding/remehaheating/internal/RemehaHeatingHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Michael Fraedrich <it-services@freddy4u.de>
Signed-off-by: Michael Fraedrich <it-services@freddy4u.de>
Signed-off-by: Michael Fraedrich <it-services@freddy4u.de>
Signed-off-by: Michael Fraedrich <it-services@freddy4u.de>
Signed-off-by: Michael Fraedrich <it-services@freddy4u.de>
Fixed the warnings and SAT errors, regenerated i18n properties file with plugin. |
lsiepel
left a comment
There was a problem hiding this comment.
Thanks @FreddyFFM. Sorry i somehow overlooked this PR and it did not end up in 5.1.0 while it was ready. I will now merge it and it will become the first new binding of 5.2.0
You could add the binding's logo to the openHAB website. See https://www.openhab.org/docs/developer/addons/#add-your-add-on-s-logo-to-the-openhab-website-and-the-ui
Signed-off-by: lsiepel <leosiepel@gmail.com>
[remehaheating] Initial contribution
Description
This PR adds a new binding for Remeha Home heating systems, enabling monitoring and control of Remeha boilers through the Remeha Home cloud service.
Classification: Novel Addition - New Binding
Key Features:
Supported Hardware:
Technical Details:
Documentation:
Code Quality:
Testing
The binding has been tested with a Remeha Calenta Ace boiler and E-Twist module and successfully:
Community testing welcome for other Remeha boiler models.
Signed-off-by: Michael Fraedrich your.email@example.com