Skip to content

Comments

[remehaheating] Initial contribution#19494

Merged
lsiepel merged 11 commits intoopenhab:mainfrom
FreddyFFM:remehaheating-5.1.x
Dec 23, 2025
Merged

[remehaheating] Initial contribution#19494
lsiepel merged 11 commits intoopenhab:mainfrom
FreddyFFM:remehaheating-5.1.x

Conversation

@FreddyFFM
Copy link
Contributor

[remehaheating] Initial contribution

Description

This PR adds a new binding for Remeha Home heating systems, enabling monitoring and control of Remeha boilers through the Remeha Home cloud service.

Classification: Novel Addition - New Binding

Key Features:

  • Real-time monitoring of room and outdoor temperatures
  • Target temperature control (5-30°C)
  • Hot water (DHW) temperature monitoring and mode control (anti-frost/schedule/continuous-comfort)
  • Water pressure monitoring with status indicator
  • System error status monitoring
  • OAuth2 PKCE authentication (same as official Remeha Home mobile app)

Supported Hardware:

  • Remeha boilers connected to Remeha Home cloud service
  • Tested with Remeha Calenta Ace boiler
  • Should work with any modern Remeha boiler with internet connectivity (E-Twist module needed)

Technical Details:

  • Cloud-based binding using Remeha API
  • Manual configuration with Remeha Home account credentials
  • Configurable refresh interval (30-3600 seconds, default 60s)
  • Proper use of Units of Measurement (Temperature, Pressure)
  • Semantic tags for channels (Measurement, Setpoint, Temperature, Pressure)
  • Comprehensive unit tests (20 tests, all passing)

Documentation:

  • Complete README with configuration examples
  • Thing and item configuration examples
  • Sitemap example included
  • Troubleshooting section

Code Quality:

  • Follows openHAB coding guidelines
  • @NonNullByDefault annotations on all main classes
  • Static code analysis: 0 errors
  • All tests passing
  • EPL 2.0 licensed with NOTICE file

Testing

The binding has been tested with a Remeha Calenta Ace boiler and E-Twist module and successfully:

  • Authenticates with Remeha Home cloud service
  • Retrieves and updates sensor values
  • Controls target temperature
  • Changes Hot Water operating modes

Community testing welcome for other Remeha boiler models.

Signed-off-by: Michael Fraedrich your.email@example.com

Add binding for Remeha Home heating systems. Supports monitoring and
control of Remeha boilers connected to the Remeha cloud service.

Features:
- Temperature monitoring and control
- Hot water (DHW) management
- System status monitoring
- OAuth2 PKCE authentication

Signed-off-by: Michael Fraedrich <it-services@freddy4u.de>
@FreddyFFM FreddyFFM requested a review from a team as a code owner October 17, 2025 09:33
Signed-off-by: Michael Fraedrich <it-services@freddy4u.de>
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thansk for contributing this binding. I had a quick initial look. The comments can be applied on multiple lines, so hopefully you can fix all places it occurs.
Readme, handler and apiclient are the three files i have not yet looked at.

@lsiepel lsiepel added the new binding If someone has started to work on a binding. For a new binding PR. label Oct 17, 2025
…nsistency

Signed-off-by: Michael Fraedrich <it-services@freddy4u.de>
@FreddyFFM FreddyFFM force-pushed the remehaheating-5.1.x branch from 1d62fd4 to fd7e987 Compare October 17, 2025 13:10
@wborn wborn requested a review from Copilot October 17, 2025 14:02
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Initial contribution of the Remeha Heating binding integrating Remeha Home cloud-connected boilers into openHAB with monitoring and basic control.

  • Adds new binding, handler, handler factory, and API client with OAuth2 PKCE flow
  • Defines thing types, channels, i18n, feature, and tests

Reviewed Changes

Copilot reviewed 21 out of 21 changed files in this pull request and generated 11 comments.

Show a summary per file
File Description
bundles/pom.xml Registers new remehaheating module in build
bom/openhab-addons/pom.xml Adds binding to BOM dependencies
CODEOWNERS Assigns ownership for new bundle
bundles/org.openhab.binding.remehaheating/pom.xml New bundle POM
bundles/org.openhab.binding.remehaheating/src/main/java/.../RemehaApiClient.java Implements OAuth2 PKCE and API calls
bundles/org.openhab.binding.remehaheating/src/main/java/.../RemehaHeatingHandler.java Thing handler logic, polling, updates, and commands
bundles/org.openhab.binding.remehaheating/src/main/java/.../RemehaHeatingHandlerFactory.java OSGi factory for handler
bundles/org.openhab.binding.remehaheating/src/main/java/.../RemehaHeatingBindingConstants.java Binding constants
bundles/org.openhab.binding.remehaheating/src/main/java/.../RemehaHeatingConfiguration.java Thing configuration class
bundles/org.openhab.binding.remehaheating/src/main/resources/OH-INF/thing/thing-types.xml Thing and channel types
bundles/org.openhab.binding.remehaheating/src/main/resources/OH-INF/i18n/remehaheating.properties I18n labels/descriptions
bundles/org.openhab.binding.remehaheating/src/main/resources/OH-INF/addon/addon.xml Add-on metadata
bundles/org.openhab.binding.remehaheating/src/main/feature/feature.xml Karaf feature definition
bundles/org.openhab.binding.remehaheating/README.md Binding documentation
tests and sample JSON Unit tests and test resource

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Signed-off-by: Michael Fraedrich <it-services@freddy4u.de>
@FreddyFFM FreddyFFM requested a review from lsiepel October 17, 2025 19:19
Signed-off-by: Michael Fraedrich <it-services@freddy4u.de>
@lsiepel
Copy link
Contributor

lsiepel commented Oct 31, 2025

Are you able to proceed @FreddyFFM ?

@FreddyFFM
Copy link
Contributor Author

Are you able to proceed @FreddyFFM ?

Sure, what is still open from you side? Did I miss something?

@lsiepel
Copy link
Contributor

lsiepel commented Oct 31, 2025

Ah, i see. Usually one comments or addss a thumbs up icon when a comment is being processed. But now i see all was addressed already. only #19494 (comment) left.
I'll proibably revisit this tomorrow and finalize my review.

Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thansk, Looked at all the files. Some comments are left. I think this PR is pretty clean already. Mainly the handler and the apiclient need some attention.

Minor suggestion: You could create a seperate folder api next to the handler, and add the apiclient and future dto's and whatever is needed into that package.

Don;t forget to:

  1. fix all warnings and SAT
  2. regenerate i18n file if not already.

Michael Fraedrich added 3 commits November 28, 2025 15:21
Signed-off-by: Michael Fraedrich <it-services@freddy4u.de>
Signed-off-by: Michael Fraedrich <it-services@freddy4u.de>
Signed-off-by: Michael Fraedrich <it-services@freddy4u.de>
@FreddyFFM FreddyFFM requested a review from lsiepel November 28, 2025 14:44
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are 4 build warnings and 5 SAT errors to fix.
I would also expect an updated properties fiole (regenerated from the i18n plugin)

Michael Fraedrich added 2 commits December 1, 2025 09:47
Signed-off-by: Michael Fraedrich <it-services@freddy4u.de>
Signed-off-by: Michael Fraedrich <it-services@freddy4u.de>
@FreddyFFM
Copy link
Contributor Author

There are 4 build warnings and 5 SAT errors to fix. I would also expect an updated properties fiole (regenerated from the i18n plugin)

Fixed the warnings and SAT errors, regenerated i18n properties file with plugin.

@FreddyFFM FreddyFFM requested a review from lsiepel December 1, 2025 09:03
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @FreddyFFM. Sorry i somehow overlooked this PR and it did not end up in 5.1.0 while it was ready. I will now merge it and it will become the first new binding of 5.2.0

You could add the binding's logo to the openHAB website. See https://www.openhab.org/docs/developer/addons/#add-your-add-on-s-logo-to-the-openhab-website-and-the-ui

Signed-off-by: lsiepel <leosiepel@gmail.com>
@lsiepel lsiepel merged commit ae7d7a8 into openhab:main Dec 23, 2025
2 checks passed
@lsiepel lsiepel added this to the 5.2 milestone Dec 23, 2025
@FreddyFFM FreddyFFM deleted the remehaheating-5.1.x branch December 23, 2025 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new binding If someone has started to work on a binding. For a new binding PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants