[avmfritz] Add support for groups of blinds#19513
Merged
lsiepel merged 2 commits intoopenhab:mainfrom Oct 21, 2025
Merged
Conversation
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for groups of blinds in the avmfritz binding, enabling control of roller shutters/blinds that are grouped together in the FRITZ!Box system.
Key Changes:
- Added new
FRITZ_GROUP_BLINDSthing type for blind groups - Moved
LevelControlModelfromDeviceModeltoAVMFritzBaseModelto enable sharing between devices and groups - Updated handler logic to support blind control for both individual devices and groups
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
AVMFritzBindingConstants.java |
Added constant and ThingTypeUID for the new blinds group type |
AVMFritzBaseModel.java |
Moved levelControlModel field and its getters/setters from DeviceModel to base class |
DeviceModel.java |
Removed levelControlModel field as it was moved to parent class |
AVMFritzBaseBridgeHandler.java |
Added logic to identify blind groups when discovering devices |
AVMFritzBaseThingHandler.java |
Updated handler to process blind updates for both devices and groups |
thing-types.xml |
Added XML configuration for the new blinds group thing type |
avmfritz.properties |
Added i18n labels for blinds group |
README.md |
Updated documentation to describe the new blinds group support |
AVMFritzDeviceListModelTest.java |
Added test data and validation test for blinds group |
AVMFritzDiscoveryServiceOSGiTest.java |
Updated test to reflect new supported thing type count |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
lsiepel
requested changes
Oct 21, 2025
Contributor
lsiepel
left a comment
There was a problem hiding this comment.
Thanks, except for the test failing and the typo discovered by copilot i have no additional comments.
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
lsiepel
approved these changes
Oct 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Christoph Weitkamp github@christophweitkamp.de