Skip to content

Comments

[matter] Fix image links#19517

Merged
lsiepel merged 1 commit intoopenhab:mainfrom
jlaur:matter-readme-images
Oct 21, 2025
Merged

[matter] Fix image links#19517
lsiepel merged 1 commit intoopenhab:mainfrom
jlaur:matter-readme-images

Conversation

@jlaur
Copy link
Contributor

@jlaur jlaur commented Oct 21, 2025

Unfortunately all four images are broken after #19470. I don't know why, since other README's have similar links:

[openhab-addons]$ grep -R --include="README.md" "<img " | grep "src=\"doc".
bundles/org.openhab.binding.modbus.e3dc/README.md:<img align="right" src="doc/E3DC_Modbus_Settings.png" alt="E3DC Modbus Settings"/>
bundles/org.openhab.binding.modbus.e3dc/README.md:<img align="right" src="doc/GrafanaPV.png" alt="Grafana PV monitoring dashboard"/>
bundles/org.openhab.binding.modbus.e3dc/README.md:<img align="right" src="doc/GrafanaCloudiness.png" alt="Grafana cloudiness forecast dashboard"/>
bundles/org.openhab.binding.mybmw/README.md:<img align="right" src="doc/vehicle-properties.png" alt="Vehicle properties overview" width="500" height="350"/>
bundles/org.openhab.binding.mybmw/README.md:<img align="right" src="doc/RawData.png" alt="Raw data example" width="400" height="125"/>
bundles/org.openhab.binding.mybmw/README.md:<img align="right" src="doc/SessionOptions.png" alt="Session options example" width="400" height="250"/>
bundles/org.openhab.binding.mybmw/README.md:<img align="right" src="doc/range-radius.png" alt="Range radius example" width="400" height="350"/>
bundles/org.openhab.binding.solarforecast/README.md:<img src="doc/APICountTransformation.png" alt="API Count Transformation Example" width="320" height="300"/>
bundles/org.openhab.binding.pegelonline/README.md:<img align="right" src="doc/Marburg.png" alt="Marburg water level measurement station" width="450" height="500"/>
bundles/org.openhab.binding.matter/README.md:<img src="doc/pairing.png" alt="Matter Pairing" width="600"/>
bundles/org.openhab.binding.matter/README.md:<img src="doc/thing-discovery.png" alt="Thing Discovery" width="600"/>
bundles/org.openhab.binding.matter/README.md:<img src="doc/bridge-settings.png" alt="Bridge Settings" width="500"/>
bundles/org.openhab.binding.matter/README.md:<img src="doc/bridge-settings-pair.png" alt="Commissioning Window" width="500"/>

I don't have time to dig further into this at the moment, so just trying to fix what I broke (and now hopefully the other two images as well).

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
@jlaur jlaur requested a review from digitaldan as a code owner October 21, 2025 18:19
@jlaur jlaur added documentation regression Regression that happened during the development of a release. Not shown on final release notes. labels Oct 21, 2025
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try this.
LGTM

@lsiepel lsiepel merged commit e157c08 into openhab:main Oct 21, 2025
4 checks passed
@lsiepel lsiepel added this to the 5.1 milestone Oct 21, 2025
@jlaur
Copy link
Contributor Author

jlaur commented Oct 23, 2025

Finally they are all working.

@jlaur jlaur deleted the matter-readme-images branch October 23, 2025 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation regression Regression that happened during the development of a release. Not shown on final release notes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants