Skip to content

Comments

[telegram] Add support for MarkdownV2#19522

Merged
lolodomo merged 1 commit intoopenhab:mainfrom
lsiepel:telegram-MarkdownV2
Nov 2, 2025
Merged

[telegram] Add support for MarkdownV2#19522
lolodomo merged 1 commit intoopenhab:mainfrom
lsiepel:telegram-MarkdownV2

Conversation

@lsiepel
Copy link
Contributor

@lsiepel lsiepel commented Oct 22, 2025

Fixes: #13723

Signed-off-by: Leo Siepel <leosiepel@gmail.com>
@lsiepel lsiepel added the enhancement An enhancement or new feature for an existing add-on label Oct 22, 2025
@lsiepel lsiepel force-pushed the telegram-MarkdownV2 branch from e4aa21e to a60ff17 Compare October 22, 2025 12:57
@cweitkamp
Copy link
Contributor

@openhab/add-ons-maintainers How can I request a review from Copilot?

@lsiepel lsiepel requested a review from Copilot October 23, 2025 11:56
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for the MarkdownV2 parse mode in the Telegram binding, addressing issue #13723. MarkdownV2 is a newer formatting option provided by the Telegram Bot API.

Key Changes:

  • Added MarkdownV2 as a new parse mode option alongside existing Markdown and HTML options
  • Updated documentation and error messages to include MarkdownV2 in the list of supported formatting modes

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
thing-types.xml Added MarkdownV2 option to parseMode configuration parameter and updated description
telegram.properties Added MarkdownV2 localization entry and updated parseMode description
TelegramHandler.java Updated error message to include MarkdownV2 in list of allowed values
README.md Updated documentation table to include MarkdownV2 as a supported parse mode value

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@lsiepel
Copy link
Contributor Author

lsiepel commented Oct 23, 2025

@openhab/add-ons-maintainers How can I request a review from Copilot?

It is offered as reviewer like anyone else. It only pops up when you have a copilot pro subscription

@cweitkamp
Copy link
Contributor

Okay, thank you for the information. Meaning using Copilot for reviews is a personal privilege and not an openHAB tool.

@wborn
Copy link
Member

wborn commented Oct 26, 2025

GitHub gives you free access to Copilot Pro if they consider you to be an open-source maintainer, see:

https://docs.github.com/en/copilot/how-tos/manage-your-account/get-free-access-to-copilot-pro

You'll get an e-mail if you qualify and then you can request reviews from Copilot.

@jlaur
Copy link
Contributor

jlaur commented Oct 27, 2025

GitHub gives you free access to Copilot Pro if they consider you to be an open-source maintainer

I wonder if openHAB is not considered popular, or if I'm not considered a maintainer.

Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@lolodomo lolodomo merged commit d75406f into openhab:main Nov 2, 2025
4 checks passed
@lolodomo lolodomo added this to the 5.1 milestone Nov 2, 2025
@lsiepel lsiepel deleted the telegram-MarkdownV2 branch November 2, 2025 12:44
@lsiepel
Copy link
Contributor Author

lsiepel commented Nov 2, 2025

GitHub gives you free access to Copilot Pro if they consider you to be an open-source maintainer

I wonder if openHAB is not considered popular, or if I'm not considered a maintainer.

Same mailadres for both copilot and github ? I was granted it automatically based on omy openHAB membership.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement An enhancement or new feature for an existing add-on

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[telegram] support for Markdownv2

5 participants