[meross] Fix cloud fallback not being called#19536
Merged
lsiepel merged 1 commit intoopenhab:mainfrom Oct 24, 2025
Merged
Conversation
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where the Meross binding failed to fall back to cloud MQTT when local device communication failed. The logic was inverted, causing the cloud fallback to execute when local communication succeeded instead of when it failed.
Key changes:
- Inverted the conditional logic to correctly trigger cloud fallback on local communication failure
- Moved cloud fallback logging outside the try-catch block for accurate error reporting
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
...nhab.binding.meross/src/main/java/org/openhab/binding/meross/internal/api/MerossManager.java
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19501
When local communication fails handling a command, the binding should fall back to the cloud mqtt broker connection. This was never happening.
@fabgio Please have a look.