Skip to content

Comments

[ojelectronics] Fix itemtype for date channels#19555

Merged
lolodomo merged 2 commits intoopenhab:mainfrom
lsiepel:ojelectronics-itemtype
Nov 2, 2025
Merged

[ojelectronics] Fix itemtype for date channels#19555
lolodomo merged 2 commits intoopenhab:mainfrom
lsiepel:ojelectronics-itemtype

Conversation

@lsiepel
Copy link
Contributor

@lsiepel lsiepel commented Oct 25, 2025

Fixes #19552

Should be backported.

Signed-off-by: Leo Siepel <leosiepel@gmail.com>
@lsiepel lsiepel added the bug An unexpected problem or unintended behavior of an add-on label Oct 25, 2025
@lsiepel lsiepel requested a review from EvilPingu as a code owner October 25, 2025 20:28
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lolodomo lolodomo merged commit 5d78d43 into openhab:main Nov 2, 2025
2 checks passed
@lolodomo lolodomo added this to the 5.1 milestone Nov 2, 2025
@lsiepel lsiepel deleted the ojelectronics-itemtype branch November 2, 2025 12:46
@lolodomo
Copy link
Contributor

For me, this one is a breaking changes and an alert should be added as users have a manual action to do to change their item type.

@lsiepel
Copy link
Contributor Author

lsiepel commented Dec 21, 2025

I do not think so. The channel was permanently broken before this fix due to the wrong itemtype. The switch was not set, updated and commands dit not work. So there is no functionality broken by this fix.
No user could have used this channel in any way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug An unexpected problem or unintended behavior of an add-on (potentially) not backward compatible

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ojelectronics] Some channels have wrong itemtype

2 participants