[miio] Add support for 2 yeelights#19558
Merged
lsiepel merged 1 commit intoopenhab:mainfrom Oct 28, 2025
Merged
Conversation
Adding support for the following models: * Yeelight LED Ceiling Light Pro (modelId: yeelink.light.ceila) * Yeelight Arwen Ceiling Light (modelId: yeelink.light.ceilb) + misc small fixes to dreame vacuum db file Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for two new Yeelight ceiling light models (ceila and ceilb) to the miio binding, along with minor formatting fixes to the Dreame vacuum database file.
- Added device definitions and channel mappings for Yeelight LED Ceiling Light Pro and Yeelight Arwen Ceiling Light
- Standardized
readmeCommentformatting in dreame.vacuum.r2209-miot.json by adding backticks - Removed extraneous blank lines and fixed documentation
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| yeelink.light.ceilb-miot.json | New device database file defining channels for Yeelight Arwen Ceiling Light with main light and ambient light controls |
| yeelink.light.ceila-miot.json | New device database file defining channels for Yeelight LED Ceiling Light Pro with basic light controls |
| dreame.vacuum.r2209-miot.json | Formatting fixes: standardized readmeComment syntax with backticks, removed blank lines, corrected label text |
| basic.properties | Added i18n property entries for the two new Yeelight devices |
| MiIoDevices.java | Registered the two new Yeelight device models in the enum |
| README.md | Updated documentation to reflect new devices, channel tables, and item file examples |
Comments suppressed due to low confidence (2)
bundles/org.openhab.binding.miio/src/main/resources/database/dreame.vacuum.r2209-miot.json:1
- The label change from 'Close' to 'Off' alters the user-facing terminology. Verify this change aligns with actual device behavior and user documentation, as 'Close' and 'Off' may have different semantic meanings in some contexts.
{
bundles/org.openhab.binding.miio/src/main/resources/database/dreame.vacuum.r2209-miot.json:1
- The label change from 'Open' to 'On' alters the user-facing terminology. Verify this change aligns with actual device behavior and user documentation, as 'Open' and 'On' may have different semantic meanings in some contexts.
{
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding support for the following models:
#19537
#19538