Skip to content

Comments

[miio] Add support for 2 yeelights#19558

Merged
lsiepel merged 1 commit intoopenhab:mainfrom
marcelrv:miio-2yeelights
Oct 28, 2025
Merged

[miio] Add support for 2 yeelights#19558
lsiepel merged 1 commit intoopenhab:mainfrom
marcelrv:miio-2yeelights

Conversation

@marcelrv
Copy link
Contributor

Adding support for the following models:

  • Yeelight LED Ceiling Light Pro (modelId: yeelink.light.ceila)
  • Yeelight Arwen Ceiling Light (modelId: yeelink.light.ceilb)
  • misc small fixes to dreame vacuum db file

#19537
#19538

Adding support for the following models:
* Yeelight LED Ceiling Light Pro (modelId: yeelink.light.ceila)
* Yeelight Arwen Ceiling Light (modelId: yeelink.light.ceilb)
+ misc small fixes to dreame vacuum db file

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
@lsiepel lsiepel requested a review from Copilot October 26, 2025 09:36
@lsiepel lsiepel added the enhancement An enhancement or new feature for an existing add-on label Oct 26, 2025
@lsiepel lsiepel changed the title [miio] Add support 2 yeelights [miio] Add support for 2 yeelights Oct 26, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for two new Yeelight ceiling light models (ceila and ceilb) to the miio binding, along with minor formatting fixes to the Dreame vacuum database file.

  • Added device definitions and channel mappings for Yeelight LED Ceiling Light Pro and Yeelight Arwen Ceiling Light
  • Standardized readmeComment formatting in dreame.vacuum.r2209-miot.json by adding backticks
  • Removed extraneous blank lines and fixed documentation

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
yeelink.light.ceilb-miot.json New device database file defining channels for Yeelight Arwen Ceiling Light with main light and ambient light controls
yeelink.light.ceila-miot.json New device database file defining channels for Yeelight LED Ceiling Light Pro with basic light controls
dreame.vacuum.r2209-miot.json Formatting fixes: standardized readmeComment syntax with backticks, removed blank lines, corrected label text
basic.properties Added i18n property entries for the two new Yeelight devices
MiIoDevices.java Registered the two new Yeelight device models in the enum
README.md Updated documentation to reflect new devices, channel tables, and item file examples
Comments suppressed due to low confidence (2)

bundles/org.openhab.binding.miio/src/main/resources/database/dreame.vacuum.r2209-miot.json:1

  • The label change from 'Close' to 'Off' alters the user-facing terminology. Verify this change aligns with actual device behavior and user documentation, as 'Close' and 'Off' may have different semantic meanings in some contexts.
{

bundles/org.openhab.binding.miio/src/main/resources/database/dreame.vacuum.r2209-miot.json:1

  • The label change from 'Open' to 'On' alters the user-facing terminology. Verify this change aligns with actual device behavior and user documentation, as 'Open' and 'On' may have different semantic meanings in some contexts.
{

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@marcelrv marcelrv requested a review from lsiepel October 27, 2025 09:56
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@lsiepel lsiepel merged commit 1890c88 into openhab:main Oct 28, 2025
3 checks passed
@lsiepel lsiepel added this to the 5.1 milestone Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement An enhancement or new feature for an existing add-on

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants