Fix documentation, grammar, and spelling in bindings P#19563
Merged
jlaur merged 11 commits intoopenhab:mainfrom Dec 29, 2025
Merged
Fix documentation, grammar, and spelling in bindings P#19563jlaur merged 11 commits intoopenhab:mainfrom
jlaur merged 11 commits intoopenhab:mainfrom
Conversation
lsiepel
requested review from
Confectrician,
Stratehm,
appzer,
cweitkamp,
gnlpfjh,
hakan42,
jeremystucki,
jsjames,
lolodomo,
magx2,
mlobstein,
niklasdoerfler,
nils,
octa22,
peuter,
stefanroellin,
theater,
wborn and
weymann
as code owners
Contributor
|
Lgtm, thanks for making the corrections |
mlobstein
reviewed
Oct 26, 2025
mlobstein
reviewed
Oct 26, 2025
bundles/org.openhab.binding.panasonicbdp/src/main/resources/OH-INF/thing/uhdplayer.xml
Outdated
Show resolved
Hide resolved
mlobstein
requested changes
Oct 26, 2025
Contributor
mlobstein
left a comment
mlobstein
left a comment
There was a problem hiding this comment.
comments left for panasonicbdp
stefanroellin
approved these changes
Oct 26, 2025
Contributor
stefanroellin
left a comment
stefanroellin
left a comment
There was a problem hiding this comment.
LGTM for pilight - thanks for your work!
mlobstein
approved these changes
Oct 26, 2025
mlobstein
reviewed
Nov 3, 2025
Contributor
Author
|
Failing build can be fixed by #19650 |
nils
approved these changes
Nov 27, 2025
Contributor
nils
left a comment
nils
left a comment
There was a problem hiding this comment.
Looks good and thanks from the pjlink binding end 👍
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Co-authored-by: mlobstein <github@lobstein.org> Signed-off-by: lsiepel <leosiepel@gmail.com>
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Contributor
Author
|
Build issue is not related. Please merge @openhab/add-ons-maintainers |
mlobstein
reviewed
Dec 14, 2025
bundles/org.openhab.binding.panasonicbdp/src/main/resources/OH-INF/i18n/panasonicbdp.properties
Outdated
Show resolved
Hide resolved
…-INF/i18n/panasonicbdp.properties Co-authored-by: mlobstein <github@lobstein.org> Signed-off-by: lsiepel <leosiepel@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves documentation quality across multiple openHAB bindings starting with "P" by fixing spelling errors, grammar issues, and inconsistencies. The changes enhance clarity and readability while maintaining technical accuracy. Key improvements include fixing typos (e.g., "Ressource" → "Resource", "Hardess" → "Hardness"), improving sentence structure and punctuation, and correcting incorrect unit specifications.
- Fixed spelling and grammatical errors across README files, properties files, and XML configuration files
- Improved consistency in terminology (e.g., "Thing" capitalization, "on or off" phrasing)
- Corrected technical errors like incorrect unit attributes in configuration parameters
Reviewed changes
Copilot reviewed 58 out of 58 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pushsafer binding files | Fixed capitalization, reordered config parameters, removed trailing period |
| pushover binding README | Improved grammar and punctuation consistency |
| pushbullet binding files | Fixed spelling ("messsage" → "message"), improved descriptions, reordered properties |
| pulseaudio binding files | Fixed "Pulseaudio" → "PulseAudio" capitalization, improved descriptions |
| publictransportswitzerland binding files | Fixed "Tab Separated" → "Tab-separated", improved descriptions |
| prowl binding files | Improved grammar, fixed "ProwlApp" → "Prowl website" |
| proteusecometer binding files | Fixed "litre" → "liters", improved example text |
| powermax binding README | Fixed "Adaptor" → "Adapter", improved grammar throughout |
| plugwiseha binding files | Fixed "Opentherm" → "OpenTherm", improved channel descriptions |
| plugwise binding files | Fixed "Zigbee" → "ZigBee", alphabetized and reorganized properties |
| plex binding README | Improved grammar and sentence structure |
| plclogo binding README | Improved clarity and fixed grammatical errors |
| playstation binding files | Fixed capitalization issues, improved descriptions |
| pjlinkdevice binding files | Improved descriptions for better clarity |
| pixometer binding files | Fixed "Ressource" → "Resource", removed extra space in pattern |
| pioneeravr binding README | Improved sentence structure for descriptions |
| pilight binding files | Fixed "band pass" → "band-pass", improved grammar |
| pihole binding files | Fixed table format issue, added missing channel labels |
| phc binding README | Fixed "don´t" → "don't", improved clarity |
| pentair binding files | Fixed "Hardess" → "Hardness", "WARRENTY" → "WARRANTY" |
| pegelonline binding README | Fixed extra bracket in item label |
| paradoxalarm binding files | Removed incorrect unit specifications, reordered properties |
| panasonicbdp binding files | Added missing state patterns, fixed "Pop-Up" → "Pop-up" |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
jlaur
requested changes
Dec 28, 2025
bundles/org.openhab.binding.pushbullet/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
Co-authored-by: Jacob Laursen <jacob-github@vindvejr.dk> Signed-off-by: lsiepel <leosiepel@gmail.com>
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
jlaur
reviewed
Dec 28, 2025
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.