Skip to content

Comments

[pythonscripting] Upgrade to Graal 25#19568

Merged
lsiepel merged 4 commits intoopenhab:mainfrom
HolgerHees:pythonscripting-graal25
Oct 29, 2025
Merged

[pythonscripting] Upgrade to Graal 25#19568
lsiepel merged 4 commits intoopenhab:mainfrom
HolgerHees:pythonscripting-graal25

Conversation

@HolgerHees
Copy link
Contributor

@HolgerHees HolgerHees commented Oct 26, 2025

Must be merged together with #19518, #19567 and a Python Scripting Graal 25 upgrade.

Signed-off-by: Holger Hees <holger.hees@gmail.com>
Signed-off-by: Holger Hees <holger.hees@gmail.com>
@HolgerHees HolgerHees marked this pull request as ready for review October 27, 2025 08:23
@HolgerHees HolgerHees requested review from a team and antroids as code owners October 27, 2025 08:23
Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.
I think this should be merged first, then the JS Scripting and MQTT HA PRs can be rebased and use thr graalvm property.

@HolgerHees
Copy link
Contributor Author

@florian-h05 @ccutrer what is the next step? I'm not allowed to merge.

@florian-h05
Copy link
Contributor

Same, so let's ask @openhab/add-ons-maintainers for their reviews

@florian-h05
Copy link
Contributor

And BTW, you referenced the wrong changelog.
And why is the build failing?

@HolgerHees
Copy link
Contributor Author

HolgerHees commented Oct 28, 2025

And why is the build failing?

This has nothing to do with my change. It is failing in org.openhab.binding.satel

@ccutrer
Copy link
Member

ccutrer commented Oct 28, 2025

It seems that sometimes when you modify files in multiple bundles, CI decides it needs to build every bundle, and the full build can be a bit flakey.

Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

Waiting for the build to finish

@HolgerHees
Copy link
Contributor Author

Waiting for the build to finish

I guess the build will fail forever. For some reason, a full build is triggered every time. And there is always an addon, which is not related to this pull request, which will fail.

@lsiepel
Copy link
Contributor

lsiepel commented Oct 29, 2025

Waiting for the build to finish

I guess the build will fail forever. For some reason, a full build is triggered every time. And there is always an addon, which is not related to this pull request, which will fail.

No it is not an addon, it is the connection that fails. Many xml files are validated. Since some days, it looks like it is hammering the web server and at some point it fails. It can be ad any addons. Some builds however do finish. Only then i can merge this PR.

@HolgerHees
Copy link
Contributor Author

Hey, I never would have thought the build process would be more exciting than any lottery draw. And it's even successful! this time! :-)

@lsiepel lsiepel merged commit cbeec8e into openhab:main Oct 29, 2025
2 of 6 checks passed
@lsiepel lsiepel added this to the 5.1 milestone Oct 29, 2025
@lsiepel lsiepel added the enhancement An enhancement or new feature for an existing add-on label Oct 29, 2025
@HolgerHees HolgerHees deleted the pythonscripting-graal25 branch October 29, 2025 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement An enhancement or new feature for an existing add-on

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants