[samsungtv] Additional hint for environment variable when using in docker container#19577
[samsungtv] Additional hint for environment variable when using in docker container#19577lolodomo merged 2 commits intoopenhab:mainfrom
Conversation
…in docker container Signed-off-by: Ber <bernhard.moser@nexeno.com>
|
I would prefer to add the suggested configuration options explicitly instead of linking to the community forums. |
|
I understand the idea behind a self contained documentation. For adding a full paragraph I am afraid, I am lacking the technical depth and the full confidence in which cases this is necessary. At the end I added the 2 mentioned environment variables and it worked for me ;-) and according to the thread for some others too. The hint would have saved me hours. I thought, an "outbound" link might be less "strict + confident" and help others as well. Would you prefer if I write something like "in case of docker and problems you might try -Dorg.jupnp.network.useInterfaces=eth0 -Dorg.jupnp.network.useAddresses=192.168.1.1 (your ip)" in your envirionment variables" (without any explaination why?) |
|
A better solution could be to set your settings in the jupnp.conf file. To be check if these settings are available. IICR I am the one who added the setting to restrict the interfaces. Edit |
|
i am open to test this (if it is from your point of view the better approach!) Any documentation somewhere, how to do that? Is this jupnp.conf file already somewhere? Any my wish would be finally, that we get it somewhere to the documentation as it really to me so many hours (unfortunatelly I have a manage switch, which could also have been a root cause). |
|
The Samsung binding is IMHO the wrong place as it is not about this binding but more generally how to setup UPnP in the context of Docker. So it should be a chapter in our OH docker page. |
|
Looks like it is already documented: In the blinding doc, you could just add a link to this page for docker users. |
|
@moserbe are you able to continue with this PR? |
Signed-off-by: lsiepel <leosiepel@gmail.com>
|
@lolodomo i corrected the readme, can you check if this is ok? |
…in docker container