Skip to content

Comments

[samsungtv] Additional hint for environment variable when using in docker container#19577

Merged
lolodomo merged 2 commits intoopenhab:mainfrom
moserbe:patch-1
Jan 1, 2026
Merged

[samsungtv] Additional hint for environment variable when using in docker container#19577
lolodomo merged 2 commits intoopenhab:mainfrom
moserbe:patch-1

Conversation

@moserbe
Copy link
Contributor

@moserbe moserbe commented Oct 27, 2025

…in docker container

…in docker container

Signed-off-by: Ber <bernhard.moser@nexeno.com>
@lsiepel
Copy link
Contributor

lsiepel commented Oct 27, 2025

I would prefer to add the suggested configuration options explicitly instead of linking to the community forums.
maybe in a separate paragraph if it is an extensive guide.

@lsiepel lsiepel changed the title Additional hint for possible helpful environment variable when using in docker container. [samsungtv] Additional hint for environment variable when using in docker container Oct 27, 2025
@moserbe
Copy link
Contributor Author

moserbe commented Oct 27, 2025

I understand the idea behind a self contained documentation.

For adding a full paragraph I am afraid, I am lacking the technical depth and the full confidence in which cases this is necessary. At the end I added the 2 mentioned environment variables and it worked for me ;-) and according to the thread for some others too. The hint would have saved me hours.

I thought, an "outbound" link might be less "strict + confident" and help others as well.

Would you prefer if I write something like "in case of docker and problems you might try -Dorg.jupnp.network.useInterfaces=eth0 -Dorg.jupnp.network.useAddresses=192.168.1.1 (your ip)" in your envirionment variables" (without any explaination why?)

@lolodomo
Copy link
Contributor

lolodomo commented Oct 28, 2025

A better solution could be to set your settings in the jupnp.conf file. To be check if these settings are available. IICR I am the one who added the setting to restrict the interfaces.

Edit
jupnp/jupnp#228

@moserbe
Copy link
Contributor Author

moserbe commented Oct 28, 2025

i am open to test this (if it is from your point of view the better approach!) Any documentation somewhere, how to do that? Is this jupnp.conf file already somewhere? Any my wish would be finally, that we get it somewhere to the documentation as it really to me so many hours (unfortunatelly I have a manage switch, which could also have been a root cause).

@lolodomo
Copy link
Contributor

The Samsung binding is IMHO the wrong place as it is not about this binding but more generally how to setup UPnP in the context of Docker. So it should be a chapter in our OH docker page.
As it is possible to either use a simple config file or set environment variables, both should be explained.

@lolodomo
Copy link
Contributor

lolodomo commented Oct 29, 2025

Looks like it is already documented:
https://www.openhab.org/docs/installation/docker.html#universal-plug-and-play-upnp
Only the variable choice is documented. To be improved.

In the blinding doc, you could just add a link to this page for docker users.

@lsiepel
Copy link
Contributor

lsiepel commented Nov 22, 2025

@moserbe are you able to continue with this PR?

@lsiepel lsiepel added the awaiting feedback Awaiting feedback from the pull request author label Dec 23, 2025
Signed-off-by: lsiepel <leosiepel@gmail.com>
@lsiepel lsiepel removed the awaiting feedback Awaiting feedback from the pull request author label Dec 29, 2025
@lsiepel
Copy link
Contributor

lsiepel commented Dec 29, 2025

@lolodomo i corrected the readme, can you check if this is ok?

Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @lsiepel

@lolodomo lolodomo merged commit 6ef5449 into openhab:main Jan 1, 2026
2 checks passed
@lolodomo lolodomo added this to the 5.2 milestone Jan 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants