Fix documentation, grammar, and spelling in bindings Q-S#19586
Merged
jlaur merged 24 commits intoopenhab:mainfrom Jan 8, 2026
Merged
Fix documentation, grammar, and spelling in bindings Q-S#19586jlaur merged 24 commits intoopenhab:mainfrom
jlaur merged 24 commits intoopenhab:mainfrom
Conversation
lsiepel
requested review from
BobRak,
Hilbrand,
J-N-K,
MikeJMajor,
MikeTheTux,
alexf2015,
andrewfg,
chaton78,
chingon007,
clinique,
dalgwen,
digitaldan,
fazioa,
jsjames,
kaikreuzer,
kgoderis,
lolodomo,
markus7017,
mherwege,
mhilbush,
msteigenberger,
octa22,
pacive,
renescherer,
seime,
syphr42,
theater and
weymann
as code owners
jlaur
requested changes
Jan 6, 2026
Contributor
jlaur
left a comment
jlaur
left a comment
There was a problem hiding this comment.
I'm finally through. 🤯 I reopened two comments and just added a few more.
bundles/org.openhab.binding.qolsysiq/src/main/resources/OH-INF/thing/panel.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.qolsysiq/src/main/resources/OH-INF/i18n/qolsysiq.properties
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.qolsysiq/src/main/resources/OH-INF/thing/partition.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.qolsysiq/src/main/resources/OH-INF/thing/partition.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.qolsysiq/src/main/resources/OH-INF/i18n/qolsysiq.properties
Outdated
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
Side note: This will conflict with #17855 where "Smartthings" is being corrected to "SmartThings" and the I18N file is not regenerated. Just a heads-up.
Contributor
Author
There was a problem hiding this comment.
Yes, thanks, will try to keep a close eye on it.
bundles/org.openhab.binding.spotify/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.spotify/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
| <type>binding</type> | ||
| <name>SqueezeBox Binding</name> | ||
| <description>This is the binding for the Logitech Squeeze Server and Players.</description> | ||
| <description>Binding for Logitech Media Server (Squeeze Server) and compatible players.</description> |
Contributor
There was a problem hiding this comment.
Actually it's now renamed to Lyrion Music Server, but let's keep that for another PR. 😉
lsiepel
commented
Jan 6, 2026
lsiepel
commented
Jan 6, 2026
lsiepel
commented
Jan 6, 2026
lsiepel
commented
Jan 6, 2026
lsiepel
commented
Jan 6, 2026
lsiepel
commented
Jan 6, 2026
lsiepel
commented
Jan 6, 2026
Co-authored-by: Jacob Laursen <jacob-github@vindvejr.dk> Signed-off-by: lsiepel <leosiepel@gmail.com>
jlaur
requested changes
Jan 6, 2026
bundles/org.openhab.binding.qolsysiq/src/main/resources/OH-INF/thing/zone.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.qolsysiq/src/main/resources/OH-INF/i18n/qolsysiq.properties
Outdated
Show resolved
Hide resolved
…/thing/zone.xml Co-authored-by: Jacob Laursen <jacob-github@vindvejr.dk> Signed-off-by: lsiepel <leosiepel@gmail.com>
Co-authored-by: Jacob Laursen <jacob-github@vindvejr.dk> Signed-off-by: lsiepel <leosiepel@gmail.com>
Co-authored-by: Jacob Laursen <jacob-github@vindvejr.dk> Signed-off-by: lsiepel <leosiepel@gmail.com>
…/i18n/qolsysiq.properties Co-authored-by: Jacob Laursen <jacob-github@vindvejr.dk> Signed-off-by: lsiepel <leosiepel@gmail.com>
Contributor
Author
|
For the sibling PR’s, please save yourself the time of commenting on dot issues for the description tags as I’ll come up with a follow up PR fixing all of them |
jlaur
reviewed
Jan 7, 2026
bundles/org.openhab.binding.qolsysiq/src/main/resources/OH-INF/i18n/qolsysiq.properties
Outdated
Show resolved
Hide resolved
jlaur
reviewed
Jan 7, 2026
bundles/org.openhab.binding.qolsysiq/src/main/resources/OH-INF/i18n/qolsysiq.properties
Outdated
Show resolved
Hide resolved
…/i18n/qolsysiq.properties Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
…/i18n/qolsysiq.properties Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
…H-INF/thing/fs-site-type.xml Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
clinique
approved these changes
Jan 7, 2026
Contributor
|
Spotless failed. |
…into spelling-7
jlaur
added a commit
to jlaur/openhab-addons
that referenced
this pull request
Jan 17, 2026
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
15 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.