Skip to content

[telegram] Add support for disabling long polling #19592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lolodomo merged 3 commits into from
Nov 3, 2025
Merged

[telegram] Add support for disabling long polling #19592

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e97024d
Add disabling longpolling
lsiepel Oct 30, 2025
afb800d
Fix param description
lsiepel Oct 30, 2025
66dcc90
Review comment
lsiepel Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bundles/org.openhab.binding.telegram/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ In order to send a message, an action must be used instead.
| `proxyHost` | None | No | Proxy host for telegram binding. |
| `proxyPort` | None | No | Proxy port for telegram binding. |
| `proxyType` | SOCKS5 | No | Type of proxy server for telegram binding (SOCKS5 or HTTP). |
| `longPollingTime` | 25 | No | Timespan in seconds for long polling the telegram API. |
| `longPollingTime` | 25 | No | Timespan in seconds for long polling the telegram API. (0 to disable) |

By default chat ids are bi-directionally, i.e. they can send and receive messages.
They can be prefixed with an access modifier:
Expand Down
12 changes: 9 additions & 3 deletions ...binding.telegram/src/main/java/org/openhab/binding/telegram/internal/TelegramHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,8 +186,11 @@ public void initialize() {
updateStatus(ThingStatus.UNKNOWN);
delayThingOnlineStatus();
TelegramBot localBot = bot = new TelegramBot.Builder(botToken).okHttpClient(botLibClient).build();
localBot.setUpdatesListener(this::handleUpdates, this::handleExceptions,
getGetUpdatesRequest(config.getLongPollingTime()));
int longPollingTime = config.getLongPollingTime();
if (longPollingTime > 0) {
localBot.setUpdatesListener(this::handleUpdates, this::handleExceptions,
getGetUpdatesRequest(longPollingTime));
}
}

private void createReceiverChatIdsAndAuthorizedSenderChatIds(List<String> chatIds) {
Expand Down Expand Up @@ -470,7 +473,10 @@ public void dispose() {
OkHttpClient localClient = botLibClient;
TelegramBot localBot = bot;
if (localClient != null && localBot != null) {
localBot.removeGetUpdatesListener();
TelegramConfiguration config = this.getConfig().as(TelegramConfiguration.class);
if (config.getLongPollingTime() > 0) {
localBot.removeGetUpdatesListener();
}
localClient.dispatcher().executorService().shutdown();
localClient.connectionPool().evictAll();
logger.debug("Telegram client closed");
Expand Down
2 changes: 1 addition & 1 deletion bundles/org.openhab.binding.telegram/src/main/resources/OH-INF/i18n/telegram.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ thing-type.config.telegram.telegramBot.botToken.description = Enter the bot toke
thing-type.config.telegram.telegramBot.chatIds.label = Chat Id(s)
thing-type.config.telegram.telegramBot.chatIds.description = One or more chat id(s). Access modifiers ("<" for inbound only, ">" for outbound only) can be used as prefix (optional).
thing-type.config.telegram.telegramBot.longPollingTime.label = Long Polling Time
thing-type.config.telegram.telegramBot.longPollingTime.description = Enter the long polling time in seconds.
thing-type.config.telegram.telegramBot.longPollingTime.description = Enter the long polling time in seconds. Set 0 to disable.
thing-type.config.telegram.telegramBot.parseMode.label = Parse Mode
thing-type.config.telegram.telegramBot.parseMode.description = Support for formatted messages, values: Markdown or HTML. Default: no formatting is used.
thing-type.config.telegram.telegramBot.parseMode.option. = No Formatting
Expand Down
2 changes: 1 addition & 1 deletion bundles/org.openhab.binding.telegram/src/main/resources/OH-INF/thing/thing-types.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@
</parameter>
<parameter name="longPollingTime" type="integer" min="0" max="50" unit="s">
<label>Long Polling Time</label>
<description>Enter the long polling time in seconds.</description>
<description>Enter the long polling time in seconds. Set 0 to disable.</description>
<default>25</default>
</parameter>
</config-description>
Expand Down