[matter] Add door state support for door lock#19595
Conversation
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: |
|
Thanks! This looks pretty good. Couple asks.
|
|
Also make sure to run |
This commit adds a door state channel to the matter door lock thing. Signed-off-by: David Masshardt <david@masshardt.ch>
b62d94d to
462cb0a
Compare
|
@digitaldan All done. The DCO check still has a problem because it expects my GitHub username, not my real name which I also set in my GitHub profile. Is this a problem? |
|
Personally i think its fine, but i'll let another maintainer chime in. Otherwise this LGTM, thanks for adding the tests and docs as well. |
There was a problem hiding this comment.
Thanks LGTM.
Your sign-off message has the real-name as required. It compares this to your settings that contain your nickname (vs real name) and becaseu this does not equal, it fails. Please adapt your configuration for future PR's automatic DCO checks.
Door state channel added to the matter door lock thing.