Skip to content

Comments

[matter] Add door state support for door lock#19595

Merged
lsiepel merged 1 commit intoopenhab:mainfrom
TheNetStriker:Matter_DoorLock_DoorState
Nov 18, 2025
Merged

[matter] Add door state support for door lock#19595
lsiepel merged 1 commit intoopenhab:mainfrom
TheNetStriker:Matter_DoorLock_DoorState

Conversation

@TheNetStriker
Copy link
Contributor

Door state channel added to the matter door lock thing.

@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/matter-binding/164601/271

@digitaldan
Copy link
Contributor

Thanks! This looks pretty good. Couple asks.

  1. Can you add a test that the channel is created if the option is present and then an onEventWithDoorState test too?
  2. Add the channel to the README
  3. Regenerate the translation file with mvn i18n:generate-default-translations for the new channel

@digitaldan
Copy link
Contributor

Also make sure to run mvn spotless:apply clean install next time you build to fix the failing PR build check

This commit adds a door state channel to the matter door lock thing.

Signed-off-by: David Masshardt <david@masshardt.ch>
@TheNetStriker TheNetStriker force-pushed the Matter_DoorLock_DoorState branch from b62d94d to 462cb0a Compare November 1, 2025 12:18
@TheNetStriker
Copy link
Contributor Author

@digitaldan All done. The DCO check still has a problem because it expects my GitHub username, not my real name which I also set in my GitHub profile. Is this a problem?

@digitaldan
Copy link
Contributor

digitaldan commented Nov 1, 2025

Personally i think its fine, but i'll let another maintainer chime in. Otherwise this LGTM, thanks for adding the tests and docs as well.

Copy link
Contributor

@digitaldan digitaldan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks LGTM.

Your sign-off message has the real-name as required. It compares this to your settings that contain your nickname (vs real name) and becaseu this does not equal, it fails. Please adapt your configuration for future PR's automatic DCO checks.

@lsiepel lsiepel merged commit f03bde1 into openhab:main Nov 18, 2025
2 checks passed
@lsiepel lsiepel added this to the 5.1 milestone Nov 18, 2025
@lsiepel lsiepel added the enhancement An enhancement or new feature for an existing add-on label Nov 18, 2025
@jlaur jlaur changed the title [matter] Door state support for door lock. [matter] Add door state support for door lock Feb 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement An enhancement or new feature for an existing add-on

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants