Skip to content

[souliss] Fix channel metadata #19597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lolodomo merged 2 commits into from
Nov 3, 2025
Merged

[souliss] Fix channel metadata #19597

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cd6bc07
Fix channel metadata
lsiepel Oct 31, 2025
1a90e31
Review comment
lsiepel Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions bundles/org.openhab.binding.souliss/src/main/resources/OH-INF/i18n/souliss.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,8 +260,8 @@ channel-type.souliss.autoMode.label = On/Off Auto Mode
channel-type.souliss.autoMode.description = Switch on/off
channel-type.souliss.button.label = Button
channel-type.souliss.button.description = Button to trigger something
channel-type.souliss.buttonReadOnly.label = Button
channel-type.souliss.buttonReadOnly.description = Button to trigger something
channel-type.souliss.buttonReadOnly.label = Status
channel-type.souliss.buttonReadOnly.description = Read-only status indicator
channel-type.souliss.dimmerBrightness.label = Dimmer Brightness
channel-type.souliss.dimmerBrightness.description = The brightness can be set in 16 steps for RGBW/White leds and in 64 steps for RGBWW leds
channel-type.souliss.fan-channel.label = Fan
Expand Down
21 changes: 16 additions & 5 deletions bundles/org.openhab.binding.souliss/src/main/resources/OH-INF/thing/thing-types.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -495,6 +495,9 @@
<channel id="lastStatusStored" typeId="lastStatusStored"/>
<channel id="healthy" typeId="healthy"/>
</channels>
<properties>
<property name="thingTypeVersion">1</property>
</properties>
<config-description>
<parameter name="node" type="integer" min="0" max="256">
<label>Node</label>
Expand Down Expand Up @@ -527,8 +530,10 @@
</channel>
<channel id="lastStatusStored" typeId="lastStatusStored"/>
<channel id="healthy" typeId="healthy"/>

</channels>
<properties>
<property name="thingTypeVersion">1</property>
</properties>
<config-description>
<parameter name="node" type="integer" min="0" max="256">
<label>Node</label>
Expand Down Expand Up @@ -568,6 +573,9 @@
<channel id="lastStatusStored" typeId="lastStatusStored"/>
<channel id="healthy" typeId="healthy"/>
</channels>
<properties>
<property name="thingTypeVersion">1</property>
</properties>
<config-description>
<parameter name="node" type="integer" min="0" max="256">
<label>Node</label>
Expand Down Expand Up @@ -773,10 +781,13 @@
<label>T58</label>
<description>Pressure measure (0, 1500) hPa</description>
<channels>
<channel id="value" typeId="power"/>
<channel id="value" typeId="pressure"/>
<channel id="lastStatusStored" typeId="lastStatusStored"/>
<channel id="healthy" typeId="healthy"/>
</channels>
<properties>
<property name="thingTypeVersion">1</property>
</properties>
<config-description>
<parameter name="node" type="integer" min="0" max="256">
<label>Node</label>
Expand Down Expand Up @@ -1058,12 +1069,12 @@

<channel-type id="buttonReadOnly">
<item-type>Switch</item-type>
<label>Button</label>
<description>Button to trigger something</description>
<label>Status</label>
<description>Read-only status indicator</description>
<category>Switch</category>
<state readOnly="true"/>
</channel-type>


<channel-type id="pulse">
<item-type>Switch</item-type>
<label>Pulse</label>
Expand Down
38 changes: 38 additions & 0 deletions bundles/org.openhab.binding.souliss/src/main/resources/OH-INF/update/instructions.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<update:update-descriptions xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xmlns:update="https://openhab.org/schemas/update-description/v1.0.0"
xsi:schemaLocation="https://openhab.org/schemas/update-description/v1.0.0 https://openhab.org/schemas/update-description-1.0.0.xsd">

<thing-type uid="souliss:t31">
<instruction-set targetVersion="1">
<update-channel id="fire">
<type>souliss:buttonReadOnly</type>
</update-channel>
</instruction-set>
</thing-type>

<thing-type uid="souliss:t41">
<instruction-set targetVersion="1">
<update-channel id="statusAlarm">
<type>souliss:buttonReadOnly</type>
</update-channel>
</instruction-set>
</thing-type>

<thing-type uid="souliss:t42">
<instruction-set targetVersion="1">
<update-channel id="statusAlarm">
<type>souliss:buttonReadOnly</type>
</update-channel>
</instruction-set>
</thing-type>

<thing-type uid="souliss:t58">
<instruction-set targetVersion="1">
<update-channel id="value">
<type>souliss:pressure</type>
</update-channel>
</instruction-set>
</thing-type>

</update:update-descriptions>