[tibber] Trigger event when day-ahead prices are available #19598
Merged
jlaur merged 1 commit intoopenhab:mainfrom Nov 3, 2025
Merged
[tibber] Trigger event when day-ahead prices are available #19598jlaur merged 1 commit intoopenhab:mainfrom
jlaur merged 1 commit intoopenhab:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new trigger channel to the Tibber binding that fires an event when day-ahead prices are successfully fetched. The change introduces version 7 of the thing type with the new event trigger channel.
- Adds a new trigger channel
eventthat firesDAY_AHEAD_PRICE_UPDATEevents - Updates thing type version from 6 to 7 with corresponding migration instructions
- Implements trigger logic in
TibberHandlerto fire event when tomorrow's prices are newly available
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| instructions.xml | Adds migration instructions for version 7 to add the new event channel |
| thing-types.xml | Increments thingTypeVersion property from 6 to 7 |
| price-group.xml | Adds the event channel to the price channel group |
| channel-types.xml | Defines the new price-event trigger channel type with DAY_AHEAD_PRICE_UPDATE event |
| TibberHandler.java | Implements logic to trigger the event when new day-ahead prices are fetched |
| TibberBindingConstants.java | Adds constants for the new event channel and event value |
| README.md | Documents the new event channel and provides usage example |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jlaur
requested changes
Nov 1, 2025
Contributor
jlaur
left a comment
jlaur
left a comment
There was a problem hiding this comment.
Thanks! Only two minor comments, otherwise LGTM.
bundles/org.openhab.binding.tibber/src/main/resources/OH-INF/update/instructions.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.tibber/src/main/resources/OH-INF/thing/channel-types.xml
Outdated
Show resolved
Hide resolved
Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com> fix copilot finding Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com> add price update event Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>
weymann
force-pushed
the
feature/tibber-price-event
branch
from
7123547 to
cce7345
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature request from community:
If day-ahead prices are fetched successfully an event is triggered via new trigger channel
eventin pricegroup.