Skip to content

Comments

Fix documentation, grammar, and spelling in bindings U-V#19602

Merged
jlaur merged 11 commits intoopenhab:mainfrom
lsiepel:spelling-u
Jan 30, 2026
Merged

Fix documentation, grammar, and spelling in bindings U-V#19602
jlaur merged 11 commits intoopenhab:mainfrom
lsiepel:spelling-u

Conversation

@lsiepel
Copy link
Contributor

@lsiepel lsiepel commented Nov 1, 2025

No description provided.

Copy link
Contributor

@mherwege mherwege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for upnpcontrol.

@lsiepel
Copy link
Contributor Author

lsiepel commented Nov 1, 2025

Failing build is not related to this PR. See #19584

Copy link
Contributor

@miloit miloit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine for me

@lsiepel lsiepel added the rebuild Triggers Jenkins PR build label Dec 12, 2025
@github-actions github-actions bot removed the rebuild Triggers Jenkins PR build label Dec 12, 2025
@lsiepel lsiepel added the rebuild Triggers Jenkins PR build label Dec 13, 2025
@github-actions github-actions bot removed the rebuild Triggers Jenkins PR build label Dec 13, 2025
@lsiepel
Copy link
Contributor Author

lsiepel commented Dec 13, 2025

Failing build is not related. Please merge to prevent further conflicts.

Copilot AI review requested due to automatic review settings December 28, 2025 17:33
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR systematically improves documentation quality across multiple openHAB bindings in the U-V alphabetical range. It focuses on correcting spelling errors, improving grammar, standardizing terminology, and enhancing clarity throughout README files, properties files, and XML configuration files.

Key improvements include:

  • Standardizing capitalization (e.g., "Thing" vs "thing", "Wi-Fi" vs "WiFi", "OLED" vs "Oled")
  • Fixing spelling errors (e.g., "Refresj" → "Refresh", "SpringSteen" → "Springsteen", "ciruit" → "circuit")
  • Improving grammar and sentence structure throughout documentation
  • Correcting table formatting and alignment issues

Reviewed changes

Copilot reviewed 45 out of 46 changed files in this pull request and generated no comments.

Show a summary per file
File Description
bundles/org.openhab.binding.volvooncall/* Fixed comment capitalization and table alignment
bundles/org.openhab.binding.volumio/README.md Fixed spacing and grammar in channel descriptions
bundles/org.openhab.binding.vizio/README.md Standardized "Thing" capitalization
bundles/org.openhab.binding.vitotronic/* Added missing max values, fixed spelling ("ciruit" → "circuit"), improved grammar
bundles/org.openhab.binding.visualcrossing/README.md Improved description clarity and conciseness
bundles/org.openhab.binding.vigicrues/README.md Standardized Thing capitalization, fixed "tower" → "toward"
bundles/org.openhab.binding.vesync/* Added outlet configuration and channels
bundles/org.openhab.binding.verisure/* Fixed duplicate option values, improved table alignment
bundles/org.openhab.binding.ventaair/README.md Standardized Thing terminology and improved table formatting
bundles/org.openhab.binding.venstarthermostat/* Improved description clarity and consistency
bundles/org.openhab.binding.velux/* Reorganized properties file sections, improved clarity
bundles/org.openhab.binding.velbus/* Fixed "OLED" capitalization, corrected label ("VMPVP1" → "VMBVP1"), improved descriptions
bundles/org.openhab.binding.vektiva/* Improved configuration descriptions and label consistency
bundles/org.openhab.binding.vdr/* Changed "Sub Title" → "Subtitle" throughout
bundles/org.openhab.binding.valloxmv/* Improved descriptions, corrected max value (1 → 100), added unit specifications
bundles/org.openhab.binding.urtsi/* Added missing "required" attribute, added unit specification
bundles/org.openhab.binding.upnpcontrol/* Fixed spelling, improved descriptions, reorganized properties file
bundles/org.openhab.binding.upb/README.md Improved clarity and grammar throughout
bundles/org.openhab.binding.unifiedremote/* Fixed incorrect channel reference, improved descriptions
bundles/org.openhab.binding.unifi/* Improved clarity, fixed grammar, standardized terminology

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I added a few comments.

Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
@lsiepel
Copy link
Contributor Author

lsiepel commented Jan 25, 2026

@Rosen01 would be appreciated if you double check the changes to the readme.md for the velbus binding. I had to fix some merge conflicts and improve at the same time.

Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for response to #19602 (comment). LGTM.

@lsiepel
Copy link
Contributor Author

lsiepel commented Jan 30, 2026

@jlaur i checked again and as far as i can see there is no issue with the velbus docs, so please merge before we get more merge conflicts. If @Rosen01 does notice something is wrong, i'll be able to adapt quickly

@Rosen01
Copy link
Contributor

Rosen01 commented Jan 30, 2026

@jlaur i checked again and as far as i can see there is no issue with the velbus docs, so please merge before we get more merge conflicts. If @Rosen01 does notice something is wrong, i'll be able to adapt quickly

The other modifications are OK for me.

…hing/channel-types.xml

Signed-off-by: lsiepel <leosiepel@gmail.com>
@jlaur jlaur merged commit 0ef60ab into openhab:main Jan 30, 2026
2 checks passed
@jlaur jlaur added this to the 5.2 milestone Jan 30, 2026
@lsiepel lsiepel deleted the spelling-u branch January 30, 2026 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants