[tuya] Avoid refresh if there are no measurables#19930
Merged
lsiepel merged 3 commits intoopenhab:mainfrom Jan 2, 2026
Merged
Conversation
Signed-off-by: Mike Jagdis <mjagdis@eris-associates.co.uk>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR attempts to disable polling when a Tuya device has only function DPs (commands) and no measurable DPs (status/sensors), as polling such devices is pointless and can cause connection issues. The change adds logic in the initialize() method to check for the presence of measurable DPs and disables polling by setting pollingInterval to 0 when none are found.
Key changes:
- Adds detection logic to identify whether any measurable DPs exist in the device schema
- Automatically disables polling when no measurables are present
- Logs when polling is disabled due to lack of measurables
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
....binding.tuya/src/main/java/org/openhab/binding/tuya/internal/handler/TuyaDeviceHandler.java
Outdated
Show resolved
Hide resolved
....binding.tuya/src/main/java/org/openhab/binding/tuya/internal/handler/TuyaDeviceHandler.java
Outdated
Show resolved
Hide resolved
....binding.tuya/src/main/java/org/openhab/binding/tuya/internal/handler/TuyaDeviceHandler.java
Outdated
Show resolved
Hide resolved
…ding/tuya/internal/handler/TuyaDeviceHandler.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: mjagdis <mjagdis@eris-associates.co.uk>
…ding/tuya/internal/handler/TuyaDeviceHandler.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: mjagdis <mjagdis@eris-associates.co.uk>
lsiepel
pushed a commit
that referenced
this pull request
Jan 2, 2026
* [tuya] Avoid refresh if there are no measurables Signed-off-by: Mike Jagdis <mjagdis@eris-associates.co.uk>
lsiepel
added
the
backported
Contributor
|
Hi! Also when I install jar with reverted #19530 provided in this comment #19880 (comment) this cycling stops. |
Collaborator
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: |
Contributor
|
fyi @mjagdis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If all the DPs are functions asking the device to refresh measured values is pointless. Some devices return a null result for DP_REFRESH, some just ignore it entirely. Ignoring it causes a timeout which leads to the binding reconnecting - over and over and over...
Fixes #19880