Open
Conversation
jlaur
requested review from
Wolfgang1966,
clinique,
jmelhus,
kjoglum,
marcelGoerentz,
psmedley and
weymann
as code owners
lsiepel
reviewed
Feb 1, 2026
bundles/org.openhab.binding.evcc/src/main/resources/OH-INF/thing/loadpoint.xml
Outdated
Show resolved
Hide resolved
jlaur
force-pushed
the
price-semantic-tags
branch
from
1a4a22d to
10597a9
Compare
weymann
requested changes
Feb 2, 2026
bundles/org.openhab.binding.tibber/src/main/resources/OH-INF/thing/channel-types.xml
Show resolved
Hide resolved
marcelGoerentz
requested changes
Feb 2, 2026
Contributor
marcelGoerentz
left a comment
marcelGoerentz
left a comment
There was a problem hiding this comment.
Values are getting calculated from EVCC.
bundles/org.openhab.binding.evcc/src/main/resources/OH-INF/thing/site.xml
Outdated
Show resolved
Hide resolved
clinique
approved these changes
Feb 2, 2026
jlaur
force-pushed
the
price-semantic-tags
branch
from
10597a9 to
b097165
Compare
marcelGoerentz
requested changes
Feb 2, 2026
bundles/org.openhab.binding.evcc/src/main/resources/OH-INF/thing/site.xml
Outdated
Show resolved
Hide resolved
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
jlaur
force-pushed
the
price-semantic-tags
branch
from
b097165 to
f1a061e
Compare
Contributor
Author
And thanks for your feedback, it was unclear for me which prices are based on calculations and which are not. 🙂 |
lsiepel
approved these changes
Feb 3, 2026
Contributor
lsiepel
left a comment
lsiepel
left a comment
There was a problem hiding this comment.
Thanks, LGTM
Waiting for the build to finish
|
LGTM for awattar |
Wolfgang1966
approved these changes
Feb 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See openhab/openhab-core#5140
Related to #19917