Skip to content

Fix AbstractEvent#payload for non-JSON payloads#491

Merged
ccutrer merged 1 commit intoopenhab:mainfrom
ccutrer:event-raw-payload
Oct 6, 2025
Merged

Fix AbstractEvent#payload for non-JSON payloads#491
ccutrer merged 1 commit intoopenhab:mainfrom
ccutrer:event-raw-payload

Conversation

@ccutrer
Copy link
Member

@ccutrer ccutrer commented Oct 3, 2025

Payloads are not guaranteed to be JSON, so if they aren't just return it directly.

Payloads are not guaranteed to be JSON, so if they aren't just
return it directly.

Signed-off-by: Cody Cutrer <cody@cutrer.us>
@ccutrer ccutrer requested a review from jimtng October 3, 2025 18:40
@jimtng
Copy link
Contributor

jimtng commented Oct 4, 2025

In which case(s) did you encounter a non json payload? There's one place where we expect a hash - in timer_event.rb. I wonder if it's ever going to encounter non-json payloads there.

@ccutrer
Copy link
Member Author

ccutrer commented Oct 4, 2025

seime/openhab-esphome#56

@ccutrer ccutrer merged commit bdf46ab into openhab:main Oct 6, 2025
24 checks passed
@ccutrer ccutrer deleted the event-raw-payload branch October 6, 2025 01:39
@ccutrer ccutrer added the bug Something isn't working label Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants