Add docs for Script Condition wrapper#492
Merged
florian-h05 merged 6 commits intoopenhab:mainfrom Oct 30, 2025
Merged
Conversation
Signed-off-by: Florian Hotze <dev@florianhotze.com>
Signed-off-by: Florian Hotze <dev@florianhotze.com>
Signed-off-by: Florian Hotze <dev@florianhotze.com>
There was a problem hiding this comment.
Pull Request Overview
This PR standardizes terminology and improves clarity in documentation and code comments. The changes focus on consistent hyphenation of compound adjectives and minor wording improvements for better readability.
- Updates "UI Based" to "UI-Based" and "File Based" to "File-Based" throughout documentation
- Improves clarity in JSDoc comments regarding dedicated context behavior
- Minor wording adjustments for better English grammar and consistency
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/rules/rules.js | Updates JSDoc comments to clarify dedicated context behavior and improve wording |
| README.md | Standardizes hyphenation of compound adjectives, improves section titles, and enhances documentation clarity throughout |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Florian Hotze <dev@florianhotze.com>
Signed-off-by: Florian Hotze <dev@florianhotze.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Florian Hotze <dev@florianhotze.com>
| - .replaceMetadata(namespace, value, configuration) ⇒ `object` | ||
| - .removeMetadata(namespace) ⇒ `object|null` | ||
| - .sendCommand(value): `value` can be a string, a number, a [`time.ZonedDateTime`](#time), a [`time.Instant`](#time) or a [`Quantity`](#quantity) | ||
| - .sendCommand(value): `value` can be a string, a number, a [`time.ZonedDateTime`](#time), a, or a [`Quantity`](#quantity) |
Contributor
There was a problem hiding this comment.
This and the next three changes do not seem right:
valuecan be a string, a number, a ZoneDateTime, a, or a Quantity.
Contributor
Author
There was a problem hiding this comment.
I reverted them in a commit to main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dedicatedContextrules.