Conversation
|
@mannemiethe Thank you for your PR. Due to the upcoming 5.1.0 release we are no in a feature freeze, meaning no new features can be merged before the 5.1.0 release is done. Your PR will be reviewed some time after the release. |
|
@florian-h05: I understand. No Problem but can review it and merge it after the release? |
|
After the release we can review and merge again 👍 |
#4173 Bundle Size — 12.54MiB (~+0.01%).649c2c9(current) vs 40ebf4b main#4172(baseline) Warning Bundle contains 2 duplicate packages – View duplicate packages Bundle metrics
Bundle size by type
Bundle analysis report Branch mannemiethe:oh-knob_add_responsi... Project dashboard Generated by RelativeCI Documentation Report issue |
|
who can review and merge this PR? |
|
@mannemiethe - I started to look at this already - but need a few days. The better place for handling resizing is at the the css level - where you could define the width/height and then the browser would handle everything for you - however the base round-slider component does not support this. The round-slider component has a few other limitations regarding some of the the theme support features (#3738) where it overrides (for some reason) any defined css color class with defaults. I'm looking at how intrusive it will be to modify the component to support classes better and in doing so, there might be a good way to use css size properties to automatically support responsiveness. Lastly, the round-slider is the only component requiring jquery in the UI. While jquery is not huge, it is not insignificant in size. I have an initial port of the round-slider component using dom7 which is working. Dom7 is what all the f7 components are built with and is syntactically similar to jquery, but there are a few deltas which i'm working through. I'll hope to have something for testing in the next few days. Assuming this goes well, the responsiveness can be done at the browser level. |
|
i mean until you can deliver this new component, it would be nice if this feature can be used. |
to fix the issue: #3204
Add responsive sizing to oh-knob widget
This PR adds responsive sizing capabilities to the
oh-knobwidget, allowing it to automatically adjust its size based on its container dimensions.Changes
responsiveconfiguration option to enable dynamic sizingresponsiveis enabled andsizeis set (1-100 or "100%"), the knob scales proportionally to fit its containerUsage
Set
responsive: truein the widget configuration to enable automatic sizing. Optionally specifysizeas a percentage (1-100 or "100%") to control the knob's size relative to its container.Implementation
oh-grid-itemand other layout widgets