Skip to content

Comments

[blockly] Fix oh_context_info block "as {type}" not working#3624

Merged
jsjames merged 1 commit intoopenhab:mainfrom
florian-h05:blockly-contextual-regression
Dec 20, 2025
Merged

[blockly] Fix oh_context_info block "as {type}" not working#3624
jsjames merged 1 commit intoopenhab:mainfrom
florian-h05:blockly-contextual-regression

Conversation

@florian-h05
Copy link
Contributor

Regression from #3376.
Also simplifies the generated code (the members of the event object are now JS strings).

Regression from openhab#3376.

Signed-off-by: Florian Hotze <dev@florianhotze.com>
@florian-h05 florian-h05 added bug Something isn't working main ui Main UI labels Dec 20, 2025
@florian-h05
Copy link
Contributor Author

@kaikreuzer @jsjames We should merge this PR in the code freeze as it fixes a critical blockly regression.

@relativeci
Copy link

relativeci bot commented Dec 20, 2025

#4084 Bundle Size — 12.55MiB (~-0.01%).

308e539(current) vs 798fa23 main#4083(baseline)

Warning

Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics  Change 1 change
                 Current
#4084
     Baseline
#4083
No change  Initial JS 1.52MiB 1.52MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 7.05% 7.11%
No change  Chunks 620 620
No change  Assets 702 702
No change  Modules 2437 2437
No change  Duplicate Modules 0 0
No change  Duplicate Code 0% 0%
No change  Packages 130 130
No change  Duplicate Packages 1 1
Bundle size by type  Change 1 change Improvement 1 improvement
                 Current
#4084
     Baseline
#4083
Improvement  JS 10.87MiB (~-0.01%) 10.87MiB
No change  CSS 846.25KiB 846.25KiB
No change  Fonts 526.1KiB 526.1KiB
No change  Media 295.6KiB 295.6KiB
No change  IMG 45.73KiB 45.73KiB
No change  Other 847B 847B

Bundle analysis reportBranch florian-h05:blockly-contextual-r...Project dashboard


Generated by RelativeCIDocumentationReport issue

@stefan-hoehn
Copy link
Contributor

A pity we both overlooked the issue in the original PR. 😢
LGTM now.

@jsjames jsjames merged commit be0da15 into openhab:main Dec 20, 2025
5 checks passed
@florian-h05 florian-h05 deleted the blockly-contextual-regression branch December 20, 2025 18:42
@florian-h05 florian-h05 added this to the 5.1 milestone Dec 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working main ui Main UI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants