8377035: [s390x] Disable JSR166 test cases which uses virtual threads#29555
8377035: [s390x] Disable JSR166 test cases which uses virtual threads#29555Harshit470250 wants to merge 5 commits intoopenjdk:masterfrom
Conversation
|
👋 Welcome back Harshit470250! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
@Harshit470250 The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
|
/issue JDK-8377035 |
|
@Harshit470250 This issue is referenced in the PR title - it will now be updated. |
Webrevs
|
In other tests we use |
|
More out of curiosity, what is the actual failure when these tests are run on s390x? @Harshit470250 would it be possible to add the failure logs in that JBS issue? |
|
|
ReentrantReadWriteLock20Test creates 64k virtual threads. If the s390 port doesn't have the VM continuations implementation then the fallback/alternative implementation will create a native thread to execute each virtual thread. So I assume this commit is thread stack or some other resources when create a native thread. Should be easy to duplicate on other platforms with -XX:+UnlockExperimentalVMOptions -XX:-VMContinuations. |
ReentrantReadWriteLock20Test.java is failing on s390 due to virtual threads which are not yet implemented on s390.
SynchronousQueue20Test.java also uses virtual thread so I am also disabling it.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/29555/head:pull/29555$ git checkout pull/29555Update a local copy of the PR:
$ git checkout pull/29555$ git pull https://git.openjdk.org/jdk.git pull/29555/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 29555View PR using the GUI difftool:
$ git pr show -t 29555Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/29555.diff
Using Webrev
Link to Webrev Comment