Skip to content

8377035: [s390x] Disable JSR166 test cases which uses virtual threads#29555

Open
Harshit470250 wants to merge 5 commits intoopenjdk:masterfrom
Harshit470250:jsr
Open

8377035: [s390x] Disable JSR166 test cases which uses virtual threads#29555
Harshit470250 wants to merge 5 commits intoopenjdk:masterfrom
Harshit470250:jsr

Conversation

@Harshit470250
Copy link
Contributor

@Harshit470250 Harshit470250 commented Feb 4, 2026

ReentrantReadWriteLock20Test.java is failing on s390 due to virtual threads which are not yet implemented on s390.
SynchronousQueue20Test.java also uses virtual thread so I am also disabling it.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8377035: [s390x] Disable JSR166 test cases which uses virtual threads (Sub-task - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/29555/head:pull/29555
$ git checkout pull/29555

Update a local copy of the PR:
$ git checkout pull/29555
$ git pull https://git.openjdk.org/jdk.git pull/29555/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 29555

View PR using the GUI difftool:
$ git pr show -t 29555

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/29555.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 4, 2026

👋 Welcome back Harshit470250! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 4, 2026

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title 8377034 8377034: Enable full JSR166TestCase.java test for s390x Feb 4, 2026
@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Feb 4, 2026
@openjdk
Copy link

openjdk bot commented Feb 4, 2026

@Harshit470250 The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@Harshit470250 Harshit470250 changed the title 8377034: Enable full JSR166TestCase.java test for s390x 8377035: Enable full JSR166TestCase.java test for s390x Feb 4, 2026
@Harshit470250 Harshit470250 changed the title 8377035: Enable full JSR166TestCase.java test for s390x 8377035: Disable JSR166 test cases which uses virtual threads Feb 4, 2026
@Harshit470250 Harshit470250 reopened this Feb 5, 2026
@Harshit470250
Copy link
Contributor Author

/issue JDK-8377035

@openjdk openjdk bot changed the title 8377035: Disable JSR166 test cases which uses virtual threads 8377035: [s390x] Disable JSR166 test cases which uses virtual threads Feb 5, 2026
@openjdk
Copy link

openjdk bot commented Feb 5, 2026

@Harshit470250 This issue is referenced in the PR title - it will now be updated.

@Harshit470250 Harshit470250 marked this pull request as ready for review February 5, 2026 05:47
@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 5, 2026
@mlbridge
Copy link

mlbridge bot commented Feb 5, 2026

Webrevs

@AlanBateman
Copy link
Contributor

failing on s390 due to virtual threads which are not yet implemented on s390.

In other tests we use @requires vm.continuations to ensure the test is only selected when the VM has the support. You are looking to skip a small subset of the j.u.concurrent tests so I see how you got here. It could use the WB API to filter on whether VMContinuations is true or false but that would be disruptive to the test in that it would need setup and run with -XX:+WhiteBoxAPI. As a short term "fix" then using !Platform.isS390x() should be okay (this is preferred to use the os.name property).

@jaikiran
Copy link
Member

jaikiran commented Feb 6, 2026

More out of curiosity, what is the actual failure when these tests are run on s390x? @Harshit470250 would it be possible to add the failure logs in that JBS issue?

@Harshit470250
Copy link
Contributor Author

OpenJDK 64-Bit Server VM warning: INFO: os::commit_memory(0x000003efa8500000, 16384, 0) failed; error='Not enough space' (errno=12)
I will add the failure logs.

@AlanBateman
Copy link
Contributor

AlanBateman commented Feb 6, 2026

OpenJDK 64-Bit Server VM warning: INFO: os::commit_memory(0x000003efa8500000, 16384, 0) failed; error='Not enough space' (errno=12) I will add the failure logs.

ReentrantReadWriteLock20Test creates 64k virtual threads. If the s390 port doesn't have the VM continuations implementation then the fallback/alternative implementation will create a native thread to execute each virtual thread. So I assume this commit is thread stack or some other resources when create a native thread.

Should be easy to duplicate on other platforms with -XX:+UnlockExperimentalVMOptions -XX:-VMContinuations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core-libs core-libs-dev@openjdk.org rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

3 participants