Skip to content

8377143: Parallel: Remove special treatment in JstatGcCapacityResults.java#29562

Open
albertnetymk wants to merge 1 commit intoopenjdk:masterfrom
albertnetymk:pgc-svc-remove-if-check
Open

8377143: Parallel: Remove special treatment in JstatGcCapacityResults.java#29562
albertnetymk wants to merge 1 commit intoopenjdk:masterfrom
albertnetymk:pgc-svc-remove-if-check

Conversation

@albertnetymk
Copy link
Member

@albertnetymk albertnetymk commented Feb 4, 2026

Remove the if (isTenuredParallelGC) { path in JstatGcCapacityResults.java because ParallelGC ensures NGC == S0C + S1C + EC like other GCs nowadays.

Test: tier1-5


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8377143: Parallel: Remove special treatment in JstatGcCapacityResults.java (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/29562/head:pull/29562
$ git checkout pull/29562

Update a local copy of the PR:
$ git checkout pull/29562
$ git pull https://git.openjdk.org/jdk.git pull/29562/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 29562

View PR using the GUI difftool:
$ git pr show -t 29562

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/29562.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 4, 2026

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 4, 2026

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8377143: Parallel: Remove special treatment in JstatGcCapacityResults.java

Reviewed-by: tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 19 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title 8377143 8377143: Parallel: Remove special treatment in JstatGcCapacityResults.java Feb 4, 2026
@openjdk openjdk bot added the serviceability serviceability-dev@openjdk.org label Feb 4, 2026
@openjdk
Copy link

openjdk bot commented Feb 4, 2026

@albertnetymk The following label will be automatically applied to this pull request:

  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 4, 2026
@mlbridge
Copy link

mlbridge bot commented Feb 4, 2026

Webrevs

@albertnetymk
Copy link
Member Author

/cc hotspot-gc

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Feb 4, 2026
@openjdk
Copy link

openjdk bot commented Feb 4, 2026

@albertnetymk
The hotspot-gc label was successfully added.

Copy link
Contributor

@tschatzl tschatzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe update copyright date.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-gc hotspot-gc-dev@openjdk.org ready Pull request is ready to be integrated rfr Pull request is ready for review serviceability serviceability-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

2 participants