8377167: javax/imageio/ReadAbortTest.java throw NPE when x11 unavailable

[sendaoYan]

Hi all,

Test javax/imageio/ReadAbortTest.java and javax/imageio/WriteAbortTest.java throw java.lang.NullPointerException when x11 display unavailable, because object path unable to initial. This PR check the path is null or not before use it, this will make test failure report friendly when x11 display unavailable but DISPLAY was seted.

Change has been verified locally on linux-x64.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8377167: javax/imageio/ReadAbortTest.java throw NPE when x11 unavailable (Bug - P4)

Reviewers

• Phil Race (@prrace - Reviewer)
• Sergey Bylokhov (@mrserb - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/29569/head:pull/29569
$ git checkout pull/29569

Update a local copy of the PR:
$ git checkout pull/29569
$ git pull https://git.openjdk.org/jdk.git pull/29569/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 29569

View PR using the GUI difftool:
$ git pr show -t 29569

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/29569.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8377167: javax/imageio/ReadAbortTest.java throw NPE when x11 unavailable

Reviewed-by: prr, serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

• 949370a: 8376756: GenShen: Improve encapsulation of generational collection set choosing
• 7922919: 8340830: Console.readLine() and Console.printf() are mutually blocking
• d49e29a: 8376405: Virtual thread crash: assert(!_current->is_suspended()) failed: must be
• ... and 1 more: https://git.openjdk.org/jdk/compare/8ad91ac1109e76ee8485bf221adeac7e1751ef17...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@sendaoYan The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (9b925c08)

[prrace]

This does not make one bit of sense. These tests do nothing with DISPLAY. They do not start AWT.

[mrserb]

This does not make one bit of sense. These tests do nothing with DISPLAY. They do not start AWT.

Since DISPLAY is set, the GraphicsEnvironment considers the system as headful and tries to connect to display. After this patch, the test will not pass in that environment but will instead show the real stack trace.

java.awt.AWTError: Can't connect to X11 window server using ':123' as the value of the DISPLAY variable.
at java.desktop/sun.awt.X11GraphicsEnvironment.initDisplay(Native Method)
at java.desktop/sun.awt.X11GraphicsEnvironment.initStatic(X11GraphicsEnvironment.java:100)
at java.desktop/sun.awt.X11GraphicsEnvironment.(X11GraphicsEnvironment.java:57)
at java.desktop/sun.awt.PlatformGraphicsInfo.createGE(PlatformGraphicsInfo.java:35)
at java.desktop/java.awt.GraphicsEnvironment$LocalGE.createGE(GraphicsEnvironment.java:89)
at java.desktop/java.awt.GraphicsEnvironment$LocalGE.(GraphicsEnvironment.java:80)
at java.desktop/java.awt.GraphicsEnvironment.getLocalGraphicsEnvironment(GraphicsEnvironment.java:102)
at java.desktop/java.awt.image.BufferedImage.createGraphics(BufferedImage.java:1167)
at ReadAbortTest.(ReadAbortTest.java:64)
at ReadAbortTest.main(ReadAbortTest.java:149)
at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
at java.base/java.lang.reflect.Method.invoke(Method.java:565)
at com.sun.javatest.regtest.agent.MainWrapper$MainTask.run(MainWrapper.java:138)
at java.base/java.lang.Thread.run(Thread.java:1516)

[prrace]

I see. An odd case.

[sendaoYan]

Sorry, I did not describe the issue clearly enough. Thanks @mrserb the additionly details.

Thanks the reviews @prrace @mrserb

/integrate

[openjdk]

Going to push as commit d93bd18.
Since your change was applied there have been 7 commits pushed to the master branch:

• 72eec52: 8377161: G1: Remove unnecessary member G1FullGCScope::_g1h
• fde77a9: 8365883: Fix P11Cipher to throw BadPaddingException for PKCS11 CKR_ENCRYPTED_DATA_INVALID error
• d0e9730: 8372980: [VectorAPI] AArch64: Add intrinsic support for unsigned min/max reduction operations
• ... and 4 more: https://git.openjdk.org/jdk/compare/8ad91ac1109e76ee8485bf221adeac7e1751ef17...master

Your commit was automatically rebased without conflicts.

[openjdk]

@sendaoYan Pushed as commit d93bd18.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.