8342934: TYPE_USE annotations printed with error causing "," in toString output#4243
Open
cushon wants to merge 1 commit intoopenjdk:pr/4242from
Open
8342934: TYPE_USE annotations printed with error causing "," in toString output#4243cushon wants to merge 1 commit intoopenjdk:pr/4242from
cushon wants to merge 1 commit intoopenjdk:pr/4242from
Conversation
|
👋 Welcome back cushon! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
This backport pull request has now been updated with issue from the original commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This backport of JDK-8342934 fixes a bug in
TypeMirror#toStringoutput when printing types with multiple type annotations.TypeMirror#toStringis specified to return a string that is "suitable for representing this type in source code". This fix causes types with multiple annotations to be printed with a space separated list of annotations, instead of using,, which would not be valid Java source. For examplejava.lang.@A @B Stringinstead ofjava.lang.@A,@B String.Progress
Integration blocker
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4243/head:pull/4243$ git checkout pull/4243Update a local copy of the PR:
$ git checkout pull/4243$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4243/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 4243View PR using the GUI difftool:
$ git pr show -t 4243Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4243.diff
Using Webrev
Link to Webrev Comment