8366424: Missing type profiling in generated Record Object methods#135
8366424: Missing type profiling in generated Record Object methods#135rm-gh-8 wants to merge 1 commit intoopenjdk:masterfrom
Conversation
|
👋 Welcome back rm-gh-8! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
This backport pull request has now been updated with issue from the original commit. |
|
|
|
Beware this patch is not in a feature release yet, so it might not be sufficiently tested for production impact. |
|
/approval request for backport of JDK-8366424: Missing type profiling in generated Record Object methods. This commit addresses a HotSpot profiling issue where shared bytecode causes "profile pollution" - multiple call sites sharing the same method profile, degrading type profiling effectiveness. This backport has internal demand Low risk - Fix addressing a test problem caused by timeout behavior. The main concern is ensuring the new timeout values are appropriate. |
|
@rm-gh-8 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
Backporting JDK-8366424: Missing type profiling in generated Record Object methods.
This commit addresses a HotSpot profiling issue where shared bytecode causes "profile pollution" - multiple call sites sharing the same method profile, degrading type profiling effectiveness.
This backport has internal demand
Ran benchmark on macos-aarch64:
Results attached:
macos-aarch64-benchmark.log
Ran related tests (passed) on linux-x64, linux-aarch64, macos-aarch64 and windows-x64:
(Passed) - make test TEST=test/jdk/java/lang/runtime
Results attached:
windows-x64-specific-test.log
macos-aarch64-specific-test.log
linux-x64-specific-test.log
linux-aarch64-specific-test.log
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/135/head:pull/135$ git checkout pull/135Update a local copy of the PR:
$ git checkout pull/135$ git pull https://git.openjdk.org/jdk25u-dev.git pull/135/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 135View PR using the GUI difftool:
$ git pr show -t 135Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/135.diff
Using Webrev
Link to Webrev Comment