Skip to content

8368335: Refactor the rest of Locale TestNG based tests to JUnit#221

Open
rm-gh-8 wants to merge 1 commit intoopenjdk:masterfrom
rm-gh-8:JDK-8368335-V25
Open

8368335: Refactor the rest of Locale TestNG based tests to JUnit#221
rm-gh-8 wants to merge 1 commit intoopenjdk:masterfrom
rm-gh-8:JDK-8368335-V25

Conversation

@rm-gh-8
Copy link
Contributor

@rm-gh-8 rm-gh-8 commented Feb 3, 2026

Backporting JDK-8368335: Refactor the rest of Locale TestNG based tests to JUnit.

This PR converts TestNG-based Locale tests to JUnit.

For parity with Oracle JDK.

Ran related tests on linux-x64, linux-aarch64, macos-aarch64 and windows-x64:

make test TEST=test/jdk/java/util/Locale

Results attached:

windows-x64-specific-test.log
macos-aarch64-specific-test.log
linux-x64-specific-test.log
linux-aarch64-specific-test.log


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8368335 needs maintainer approval

Issue

  • JDK-8368335: Refactor the rest of Locale TestNG based tests to JUnit (Sub-task - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/221/head:pull/221
$ git checkout pull/221

Update a local copy of the PR:
$ git checkout pull/221
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/221/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 221

View PR using the GUI difftool:
$ git pr show -t 221

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/221.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 3, 2026

👋 Welcome back rm-gh-8! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 3, 2026

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 5d93242028dfc68b838a8efb0fbc4de3fea7fa0d 8368335: Refactor the rest of Locale TestNG based tests to JUnit Feb 3, 2026
@openjdk
Copy link

openjdk bot commented Feb 3, 2026

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Feb 3, 2026
@rm-gh-8 rm-gh-8 marked this pull request as ready for review February 3, 2026 20:11
@openjdk
Copy link

openjdk bot commented Feb 3, 2026

⚠️ @rm-gh-8 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 3, 2026
@mlbridge
Copy link

mlbridge bot commented Feb 3, 2026

Webrevs

@rm-gh-8
Copy link
Contributor Author

rm-gh-8 commented Feb 4, 2026

/approval request for backport of JDK-8368335: Refactor the rest of Locale TestNG based tests to JUnit.

This is a test fix.

For parity with Oracle JDK.

@openjdk
Copy link

openjdk bot commented Feb 4, 2026

@rm-gh-8
8368335: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Feb 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant