Skip to content

8369881: C2: Unexpected node in SuperWord truncation: ReverseBytesS, ReverseBytesUS#233

Open
vish-chan wants to merge 1 commit intoopenjdk:masterfrom
vish-chan:8369881
Open

8369881: C2: Unexpected node in SuperWord truncation: ReverseBytesS, ReverseBytesUS#233
vish-chan wants to merge 1 commit intoopenjdk:masterfrom
vish-chan:8369881

Conversation

@vish-chan
Copy link
Contributor

@vish-chan vish-chan commented Feb 4, 2026

Clean backport of 8369881: C2: Unexpected node in SuperWord truncation: ReverseBytesS, ReverseBytesUS

Fixes fuzzer-discovered assert failure in SuperWord truncation for ReverseBytesS and ReverseBytesUS nodes. Adds missing nodes to truncation switch statement and includes test cases for both.

Additional Testing:

  • New regression test fails without the fix, passes with it.
  • Linux x86_64 server fastebug compiler tests.

Progress

  • Change must not contain extraneous whitespace
  • JDK-8369881 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8369881: C2: Unexpected node in SuperWord truncation: ReverseBytesS, ReverseBytesUS (Bug - P3 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/233/head:pull/233
$ git checkout pull/233

Update a local copy of the PR:
$ git checkout pull/233
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/233/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 233

View PR using the GUI difftool:
$ git pr show -t 233

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/233.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 4, 2026

👋 Welcome back vish-chan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 4, 2026

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport aa194c6a5a21aca64d454e4c5eeed1464c8f190b 8369881: C2: Unexpected node in SuperWord truncation: ReverseBytesS, ReverseBytesUS Feb 4, 2026
@openjdk
Copy link

openjdk bot commented Feb 4, 2026

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Feb 4, 2026
@vish-chan vish-chan marked this pull request as ready for review February 4, 2026 23:18
@openjdk
Copy link

openjdk bot commented Feb 4, 2026

⚠️ @vish-chan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 4, 2026
@mlbridge
Copy link

mlbridge bot commented Feb 4, 2026

Webrevs

@vish-chan
Copy link
Contributor Author

vish-chan commented Feb 5, 2026

/approval request for Clean backport of 8369881: C2: Unexpected node in SuperWord truncation: ReverseBytesS, ReverseBytesUS

This is a low risk fix adding 2 missing node types to Superword non-truncation list. Fixes debug assert failure with no impact in product.

@openjdk
Copy link

openjdk bot commented Feb 5, 2026

@vish-chan
8369881: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Feb 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant