Draft
Conversation
Contributor
|
@shimwell The reason that we have that separate JSON file of transport nuclides is explained in the description of #41. TENDL itself includes >2000 incident neutron files and so the predetermined list represents a reasonable subset of nuclides (630) to use for depletion purposes. If we get to the point where the depletion chain can list all possible reactions but a user has a way to specify a subset of nuclides/reactions they want to track during depletion, that would be a good point to switch over to the approach you've proposed here. |
Member
Author
|
I guess all the nuclides and all the reactions is really going to blow up the memory. I guess we keep this PR in draft then just in case we get that filtering of depletion chain feature at a later date |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Admittedly I've not tinkered with this repo for a while but while looking into the feasability of adding TENDL 2015/ 2017 and 2021 chain files I noticed this part of the code that looks up the transportable endf files. I think we can just grep for these files and don't need to have a hard coded list. Perhaps I am missing something here?