Add truncated normal distribution support#3761
Open
paulromano wants to merge 6 commits intoopenmc-dev:developfrom
Open
Add truncated normal distribution support#3761paulromano wants to merge 6 commits intoopenmc-dev:developfrom
paulromano wants to merge 6 commits intoopenmc-dev:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR extends the
Normaldistribution class to support optional truncation bounds. Normal distributions are sometimes used for source sampling, but their infinite support makes them problematic for biased sampling. OpenMC currently does not let you use a normal distribution as a bias for another distribution with finite support because of the mismatched domains. Truncation allows the normal distribution to be restricted to match the support of the target distribution. A truncated normal is simply specified by passing one or both of thelowerandupperarguments. Without these arguments, the untruncated behavior is preserved.Thanks to @akoen for inspiration!
Checklist