Add capability for ini file usage from the command line#432
Add capability for ini file usage from the command line#432brockn8r wants to merge 1 commit intoopenscopeproject:masterfrom
Conversation
|
Looks good, 2 general comments:
Actually you are checking locations where the board file is or where the plugin is. Which is correct.
That's why you need to use defaults.
It is intentionally not saved to the ini file because it is supposed to be dynamically chosen (unless explicitly specified by user). |
|
I think its unlikely that @brockn8r will be back to work on this (he is no longer in the role he was when creating it). If @Funkenjaeger wants to take ownership of the PR, great! Otherwise I'm happy to make a new one with those two commits.... |
|
@amauragis be my guest! I'm distracted with other projects lately, so it'd probably be a while yet until I focused on this enough to get it over the line. |
|
Any update? |
A couple notes:
This works mostly for us. We run on Linux (Fedora). I say mostly because there are still some oddities. For example, other than bom_dest_dir and open_browser, I still pass another option (--extra-data-file) on the command line even though I am using the ini file because I haven't figured out why it wasn't working.