This repository was archived by the owner on Nov 9, 2023. It is now read-only.
Allow non-integer id formats such as hex#2
Closed
pelshoff wants to merge 3 commits intoopensdks:masterfrom
Closed
Conversation
added 3 commits
February 27, 2018 11:39
|
I ran into the same issue. Please merge. |
Merged
Contributor
|
FYI: I've forked, updated to 1.6 of the SDK ánd left the hex-change... (see #3) |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey there,
Rabobank seems to not have accounted for shops using non-numeric ids. I don't think it makes sense to doubly-verify that id matches the id the signature is calculated for; the calculation itself already does that. All we want from the payment completed response is to make sure the orderID we sent over the wire is the same that comes back, whether it's 123, '1ab' or 'cow'. What do you think?
Kind regards,
Pim Elshoff
Procurios